[Infra UI] Add infra serverless functional tests #168621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jennypavlova
added
Team:Infra Monitoring UI - DEPRECATED
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
|
Pinging @elastic/infra-monitoring-ui (Team:Infra Monitoring UI) |
crespocarlos
approved these changes
Oct 17, 2023
|
|
||
| describe('#Single Host Flyout', () => { | ||
| before(async () => { | ||
| // await setHostViewEnabled(true); |
There was a problem hiding this comment.
Do we need this line?
There was a problem hiding this comment.
No, it will be added as part of the settings in this issue so it won't be needed in this form anymore. Thanks for catching that!
|
|
||
| describe('#Page Content', () => { | ||
| before(async () => { | ||
| // await setHostViewEnabled(true); |
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
jennypavlova
deleted the
166749-infra-ui-serverless-e2e-functional-testing
branch
dej611
pushed a commit
to dej611/kibana
that referenced
this pull request
Oct 17, 2023
Closes elastic#166749 ## Summary This PR adds serverless functional tests for the infra plugin. The main goal is to make sure that the app loads all the pages and successfully navigates between them. As we already have functional tests covering the whole functionality here we want to cover the differences with serverless and some basic checks ensuring that base functionality works correctly. - Update the test to cover disabling the create rule button added [here](elastic#167978): ([x-pack/test_serverless/functional/test_suites/observability/infra/hosts_page.ts](elastic@87fb991#diff-76bd05d3fed2c44187682e27b4030ddb9cba1a36235321e0db1b371ef6739cc9))⚠️ The tests for the second AC point related to user roles will go in a[ separate issue ](elastic#168931) Test server run: `node scripts/functional_tests_server.js --config=x-pack/test_serverless/functional/test_suites/observability/config.ts` Tests run: `node scripts/functional_test_runner --config=x-pack/test_serverless/functional/test_suites/observability/config.ts --grep "Observability Infra"`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #166749
Summary
This PR adds serverless functional tests for the infra plugin. The main goal is to make sure that the app loads all the pages and successfully navigates between them. As we already have functional tests covering the whole functionality here we want to cover the differences with serverless and some basic checks ensuring that base functionality works correctly.
Test server run:
node scripts/functional_tests_server.js --config=x-pack/test_serverless/functional/test_suites/observability/config.tsTests run:
node scripts/functional_test_runner --config=x-pack/test_serverless/functional/test_suites/observability/config.ts --grep "Observability Infra"