Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Search] Unskip Search examples handling warnings test #168367

Merged
merged 14 commits into from
Oct 12, 2023

Conversation

kertal
Copy link
Member

@kertal kertal commented Oct 9, 2023

Summary

This PR improves the code testing search source warning in our Search examples, to stabilize it because it was flaky

Flaky test runner 200x
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3440

Resolves #166484

Checklist

@kertal kertal self-assigned this Oct 9, 2023
@kertal kertal added release_note:skip Skip the PR/issue when compiling release notes Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. Feature:Search Querying infrastructure in Kibana labels Oct 11, 2023
@kertal kertal changed the title Search examples experimental unzip Unskip Search examples handling warnings with search source fetch should show search warnings in results tab functional test Oct 11, 2023
@kertal kertal changed the title Unskip Search examples handling warnings with search source fetch should show search warnings in results tab functional test [Search] Unskip Search examples handling warnings test Oct 11, 2023
@kertal kertal marked this pull request as ready for review October 11, 2023 09:54
@kertal kertal requested a review from a team as a code owner October 11, 2023 09:54
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@kertal
Copy link
Member Author

kertal commented Oct 11, 2023

@elasticmachine merge upstream

@kertal
Copy link
Member Author

kertal commented Oct 11, 2023

@elasticmachine merge upstream

@kertal
Copy link
Member Author

kertal commented Oct 11, 2023

@elasticmachine merge upstream

Copy link
Contributor

@davismcphee davismcphee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for fixing these stubborn tests! Current CI failures don't seem related and the flaky runner agrees, so I think we're good to merge when it passes CI 👍

davismcphee added a commit to davismcphee/kibana that referenced this pull request Oct 11, 2023
@kertal
Copy link
Member Author

kertal commented Oct 12, 2023

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #4 / Monitoring app Logstash nodes mb "after all" hook for "should filter for specific nodes"
  • [job] [logs] FTR Configs #4 / Monitoring app Logstash nodes mb "before all" hook for "should have Logstash Cluster Summary Status showing correct info"

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @kertal

@kertal kertal added the backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) label Oct 12, 2023
@kertal kertal merged commit 4302059 into elastic:main Oct 12, 2023
2 checks passed
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 12, 2023
## Summary

Improves and unskips the code testing search source warning in our Search examples.

Flaky test runner 200x
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3440

Resolves elastic#166484

(cherry picked from commit 4302059)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.11

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Oct 12, 2023
… (#168669)

# Backport

This will backport the following commits from `main` to `8.11`:
- [[Search] Unskip Search examples handling warnings test
(#168367)](#168367)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Matthias
Wilhelm","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-10-12T05:35:12Z","message":"[Search]
Unskip Search examples handling warnings test (#168367)\n\n##
Summary\r\n\r\nImproves and unskips the code testing search source
warning in our Search examples.\r\n\r\nFlaky test runner
200x\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3440\r\n\r\nResolves
#166484","sha":"4302059b4ec4776d12578840ab4a649719ef81f4","branchLabelMapping":{"^v8.12.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Search","release_note:skip","Team:DataDiscovery","backport:prev-minor","v8.12.0"],"number":168367,"url":"https://github.com/elastic/kibana/pull/168367","mergeCommit":{"message":"[Search]
Unskip Search examples handling warnings test (#168367)\n\n##
Summary\r\n\r\nImproves and unskips the code testing search source
warning in our Search examples.\r\n\r\nFlaky test runner
200x\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3440\r\n\r\nResolves
#166484","sha":"4302059b4ec4776d12578840ab4a649719ef81f4"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.12.0","labelRegex":"^v8.12.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/168367","number":168367,"mergeCommit":{"message":"[Search]
Unskip Search examples handling warnings test (#168367)\n\n##
Summary\r\n\r\nImproves and unskips the code testing search source
warning in our Search examples.\r\n\r\nFlaky test runner
200x\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3440\r\n\r\nResolves
#166484","sha":"4302059b4ec4776d12578840ab4a649719ef81f4"}}]}]
BACKPORT-->

Co-authored-by: Matthias Wilhelm <[email protected]>
dej611 pushed a commit to dej611/kibana that referenced this pull request Oct 17, 2023
## Summary

Improves and unskips the code testing search source warning in our Search examples.

Flaky test runner 200x
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3440

Resolves elastic#166484
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) Feature:Search Querying infrastructure in Kibana release_note:skip Skip the PR/issue when compiling release notes Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. v8.11.0 v8.12.0
Projects
None yet
5 participants