-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Search] Unskip Search examples handling warnings test #168367
Conversation
Pinging @elastic/kibana-data-discovery (Team:DataDiscovery) |
@elasticmachine merge upstream |
@elasticmachine merge upstream |
@elasticmachine merge upstream |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for fixing these stubborn tests! Current CI failures don't seem related and the flaky runner agrees, so I think we're good to merge when it passes CI 👍
@elasticmachine merge upstream |
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]
History
To update your PR or re-run it, just comment with: cc @kertal |
## Summary Improves and unskips the code testing search source warning in our Search examples. Flaky test runner 200x https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3440 Resolves elastic#166484 (cherry picked from commit 4302059)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
… (#168669) # Backport This will backport the following commits from `main` to `8.11`: - [[Search] Unskip Search examples handling warnings test (#168367)](#168367) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Matthias Wilhelm","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-10-12T05:35:12Z","message":"[Search] Unskip Search examples handling warnings test (#168367)\n\n## Summary\r\n\r\nImproves and unskips the code testing search source warning in our Search examples.\r\n\r\nFlaky test runner 200x\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3440\r\n\r\nResolves #166484","sha":"4302059b4ec4776d12578840ab4a649719ef81f4","branchLabelMapping":{"^v8.12.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Search","release_note:skip","Team:DataDiscovery","backport:prev-minor","v8.12.0"],"number":168367,"url":"https://github.com/elastic/kibana/pull/168367","mergeCommit":{"message":"[Search] Unskip Search examples handling warnings test (#168367)\n\n## Summary\r\n\r\nImproves and unskips the code testing search source warning in our Search examples.\r\n\r\nFlaky test runner 200x\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3440\r\n\r\nResolves #166484","sha":"4302059b4ec4776d12578840ab4a649719ef81f4"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.12.0","labelRegex":"^v8.12.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/168367","number":168367,"mergeCommit":{"message":"[Search] Unskip Search examples handling warnings test (#168367)\n\n## Summary\r\n\r\nImproves and unskips the code testing search source warning in our Search examples.\r\n\r\nFlaky test runner 200x\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3440\r\n\r\nResolves #166484","sha":"4302059b4ec4776d12578840ab4a649719ef81f4"}}]}] BACKPORT--> Co-authored-by: Matthias Wilhelm <[email protected]>
## Summary Improves and unskips the code testing search source warning in our Search examples. Flaky test runner 200x https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3440 Resolves elastic#166484
Summary
This PR improves the code testing search source warning in our Search examples, to stabilize it because it was flaky
Flaky test runner 200x
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3440
Resolves #166484
Checklist