Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Profiling] Remove Security checks #168341

Merged

Conversation

cauemarcondes
Copy link
Contributor

@cauemarcondes cauemarcondes commented Oct 9, 2023

  • Use Kibana internal user to fetch Profiling status.
  • Check if current user has superadmin role to set up Profiling.
  • Viewer users: disable set up button when Profiling is not yet initialised.
  • Remove Profiling role creation and check.
Screenshot 2023-10-06 at 10 50 44 Screenshot 2023-10-06 at 10 51 15

@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • /oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@cauemarcondes cauemarcondes added the release_note:skip Skip the PR/issue when compiling release notes label Oct 9, 2023
@cauemarcondes cauemarcondes marked this pull request as ready for review October 9, 2023 13:11
@cauemarcondes cauemarcondes requested a review from a team as a code owner October 9, 2023 13:11
@cauemarcondes cauemarcondes marked this pull request as draft October 9, 2023 13:42
@cauemarcondes cauemarcondes marked this pull request as ready for review October 10, 2023 12:27
@cauemarcondes cauemarcondes requested a review from a team as a code owner October 10, 2023 12:27
@botelastic botelastic bot added the Team:APM All issues that need APM UI Team support label Oct 11, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:APM)

@cauemarcondes cauemarcondes requested a review from legrego October 23, 2023 08:46
@cauemarcondes cauemarcondes requested a review from a team as a code owner October 24, 2023 13:22
@cauemarcondes cauemarcondes requested a review from legrego October 24, 2023 13:34
Copy link
Contributor

@jbcrail jbcrail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

Copy link
Contributor

@kpatticha kpatticha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

APM changes LGTM

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
profilingDataAccess 24 22 -2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
profiling 357.2KB 357.5KB +248.0B
Unknown metric groups

API count

id before after diff
profilingDataAccess 24 22 -2

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@cauemarcondes cauemarcondes removed the request for review from kc13greiner October 27, 2023 14:36
@cauemarcondes cauemarcondes merged commit 1d54963 into elastic:main Oct 27, 2023
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Oct 27, 2023
@cauemarcondes cauemarcondes deleted the profiling-remove-security-on-setup branch October 27, 2023 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting ci:build-cloud-image release_note:skip Skip the PR/issue when compiling release notes Team:APM All issues that need APM UI Team support v8.12.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants