Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[discover ] Remove extra field list request #168315

Merged
merged 5 commits into from
Dec 1, 2023
Merged

[discover ] Remove extra field list request #168315

merged 5 commits into from
Dec 1, 2023

Conversation

mattkime
Copy link
Contributor

@mattkime mattkime commented Oct 9, 2023 •
edited
Loading

Summary

The data view picker reloads the field list when the data view is changed. Discover also does this. It doesn't need to happen twice so this removes the discover field list reload call.

Addresses #167221

@kertal kertal added the Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. label Nov 8, 2023
@mattkime mattkime changed the title no need to refresh field list as data view picker is refreshing it fo… [discover ] Remove extra field list request Nov 30, 2023
@mattkime mattkime self-assigned this Nov 30, 2023
@mattkime mattkime added Feature:Discover Discover Application release_note:skip Skip the PR/issue when compiling release notes labels Nov 30, 2023
@mattkime mattkime marked this pull request as ready for review November 30, 2023 21:04
@mattkime mattkime requested a review from a team as a code owner November 30, 2023 21:04
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

lukasolson
lukasolson approved these changes Nov 30, 2023
View reviewed changes
Copy link
Member

@lukasolson lukasolson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and I'm seeing one less call, and new fields still seem to be showing up.

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
discover 589.6KB 589.6KB -6.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @mattkime

@mattkime mattkime merged commit d85ebc5 into elastic:main Dec 1, 2023
31 checks passed
@kibanamachine kibanamachine added v8.12.0 backport:skip This commit does not require backporting labels Dec 1, 2023
@kertal kertal mentioned this pull request Dec 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kertal kertal kertal left review comments

@lukasolson lukasolson lukasolson approved these changes

Assignees

@mattkime mattkime

Labels
backport:skip This commit does not require backporting Feature:Discover Discover Application release_note:skip Skip the PR/issue when compiling release notes Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. v8.12.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mattkime @elasticmachine @kibana-ci @kertal @lukasolson @kibanamachine