-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[rollup][licensing_management][grokdebugger] Migrate deprecated EuiPage*
components
#168300
[rollup][licensing_management][grokdebugger] Migrate deprecated EuiPage*
components
#168300
Conversation
Pinging @elastic/eui-team (EUI) |
@elasticmachine merge upstream |
@elasticmachine merge upstream |
Pinging @elastic/platform-deployment-management (Team:Deployment Management) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @cee-chen! Thanks for your help on this! Looks like there were a few plugins we missed on our original checklist (#161413) 😬
I did not test License Management (forgot it's disabled on cloud), but I'm seeing a few regressions in Rollups and Grokdebugger. I'm wondering if it'd be easier for an engineer on the Management team to pick this up as they're more familiar with the plugins. That said, we may not be able to get to this for another week or so. WDYT?
x-pack/plugins/grokdebugger/public/components/grok_debugger/grok_debugger.js
Outdated
Show resolved
Hide resolved
x-pack/plugins/rollup/public/crud_app/sections/job_list/job_list.js
Outdated
Show resolved
Hide resolved
x-pack/plugins/rollup/public/crud_app/sections/job_create/job_create.js
Outdated
Show resolved
Hide resolved
Apologies for the late response (was on PTO) and thank you so much for the thorough QA @alisonelizabeth! I can take a look at the regressions some time this week, or if y'all want to take over this PR (or branch from it), that'd be totally great too! I have no strong feelings about whoever completes the work as long as it gets done without borking your UIs 😄 |
Np! If you're up for taking another look at it this week, that would be great. I think we're still a week or so out before we could pick this up. |
+ remove unnecessary width `style` - already handled by `EuiPageSection`
a971985
to
8731782
Compare
Alrighty, I think I should have addressed all the layout regressions! I switch between the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working through this @cee-chen! This is looking great.
I only noticed one minor thing with Grokdebugger. In the current UI, the page has an all-white background, but now only the content has the white background. Let me know what you think.
Gah, that's what I get for not QAing on a larger screen. That should be fixed now in 2e4c800 - let me know if not! I also took another quick pass at the other pages/plugins to make sure they didn't have the same problem, and I'm pretty sure it was just that one. 🤞 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great now! Thanks again for working on this.
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
Summary
EUI will shortly be removing several deprecated
EuiPage*
components, and we're updating a few remaining Kibana usages of these deprecated components ahead of time.See #161872 for other similar tasks with more information about this effort.