[Security Solution][Elastic AI Assistant] Refactors Knowledge Base feature flag to UI feature toggle #167935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spong
added
release_note:skip
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
.../kbn-elastic-assistant/impl/assistant/settings/use_settings_updater/use_settings_updater.tsx
Outdated
Show resolved
Hide resolved
andrew-goldstein
approved these changes
Oct 3, 2023
There was a problem hiding this comment.
Thanks @spong for enabling the KB via the UI toggle! 🙏
✅ Desk tested locally
LGTM 🚀
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: cc @spong |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR refactors the
assistantLangChaincode feature flag introduced in #164908, to be a UI feature toggle that users can enable/disable via theKnowledge Baseassistant advanced settings.Left image shows the feature disabled, and the right image shows the feature partly enabled. If ELSER is configured, the UI will attempt to install all resources automatically for a one-click UX, however if ELSER is not configured, or there are failures, the user can manually enable the Knowledge Base or ES|QL base documentation:
Also, since this code feature flag was shared with the model evaluator experimental feature, a
modelEvaluatorEnabledflag has been plumbed to fully decouple the two settings. Now only the model evaluator is enabled when setting security Solution Advanced setting:and the previous
assistantLangChaincode feature flag is now enabled by simply toggling on the Knowledge Base in the settings shown above.Note
Even if ELSER isn't configured, and the knowledge base/docs aren't setup, if the Knowledge Base is enabled, the LangChain code path will still be enabled as intended, but we can change this behavior if testing shows this is not ideal.
Checklist
Delete any items that are not applicable to this PR.