Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security solution] Bedrock connector - fix svg in dark mode #167835

Merged
merged 1 commit into from
Oct 2, 2023
Merged

[Security solution] Bedrock connector - fix svg in dark mode #167835

merged 1 commit into from
Oct 2, 2023

Conversation

stephmilovic
Copy link
Contributor

@stephmilovic stephmilovic commented Oct 2, 2023 •
edited
Loading

Summary

We had a fill argument on the path that I didn't catch. After removing that, the <Logo {...props} /> delivers the proper fill argument in dark mode and light mode.

Screenshot 2023-10-02 at 3 43 42 PM Screenshot 2023-10-02 at 3 45 48 PM

@stephmilovic stephmilovic added release_note:skip Skip the PR/issue when compiling release notes Team:Threat Hunting Security Solution Threat Hunting Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.11.0 labels Oct 2, 2023
@stephmilovic stephmilovic requested a review from a team as a code owner October 2, 2023 21:46
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

ymao1
ymao1 approved these changes Oct 2, 2023
View reviewed changes
Copy link
Contributor

@ymao1 ymao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stephmilovic stephmilovic enabled auto-merge (squash) October 2, 2023 22:00
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
stackConnectors 511.1KB 511.1KB -15.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@stephmilovic stephmilovic merged commit 0ecd1eb into elastic:main Oct 2, 2023
9 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ymao1 ymao1 ymao1 approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting Security Solution Threat Hunting Team v8.11.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@stephmilovic @elasticmachine @kibana-ci @ymao1 @kibanamachine