Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UnifiedDataTable] add row line-height override support #167725

Merged
merged 3 commits into from
Oct 2, 2023
Merged

[UnifiedDataTable] add row line-height override support #167725

merged 3 commits into from
Oct 2, 2023

Conversation

opauloh
Copy link
Contributor

@opauloh opauloh commented Oct 2, 2023

Summary

This PR supports overriding the default row line height of the EuiGrid component used by the UnifiedDataTable component.

It achieves this by adding an optional rowLineHeightOverride prop on the UnifiedDataTable component, if rowLineHeightOverride is passed it overrides the row line height, otherwise it fallbacks to the default defined in the defaultRowLineHeight constant.

@opauloh opauloh added release_note:skip Skip the PR/issue when compiling release notes 8.11 candidate Feature:UnifiedDataTable labels Oct 2, 2023
@opauloh opauloh requested a review from a team as a code owner October 2, 2023 02:08
jughosta
jughosta reviewed Oct 2, 2023
View reviewed changes
Copy link
Contributor

@jughosta jughosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @opauloh,

Changes in the PR look good! Would it possible to also add jest tests for it?

@opauloh
Copy link
Contributor Author

opauloh commented Oct 2, 2023

Would it possible to also add jest tests for it?

Absolutely! My bad for not adding them in the first place, can you check again?

jughosta
jughosta approved these changes Oct 2, 2023
View reviewed changes
Copy link
Contributor

@jughosta jughosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
Thanks!

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #7 / EPM Endpoints When installing system integration in multiple spaces should install kibana assets

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
discover 565.9KB 566.0KB +102.0B
Unknown metric groups

API count

id before after diff
@kbn/unified-data-table 93 94 +1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@opauloh opauloh merged commit 66b1c7f into elastic:main Oct 2, 2023
@kibanamachine kibanamachine added v8.11.0 backport:skip This commit does not require backporting labels Oct 2, 2023
@kfirpeled kfirpeled mentioned this pull request Oct 3, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jughosta jughosta jughosta approved these changes

Assignees
No one assigned
Labels
8.11 candidate backport:skip This commit does not require backporting Feature:UnifiedDataTable release_note:skip Skip the PR/issue when compiling release notes v8.11.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@opauloh @kibana-ci @jughosta @kibanamachine