-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[8.10][Osquery] Backport of Move Osquery/cypress configurations close to cypress (#167428) #167614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lastic#167428) The osquery-cypress package was referring to configurations from a parent folder. This caused difficulties with having to exclude/include the same files in the `tsconfig.json`s, leading to hard-to-resolve typescript issues. This PR moves the configs in, and cleans up redundancies and type errors. chore(osquery): move osquery/cypress configs to cypress folder, fix type errors --------- Co-authored-by: Patryk Kopyciński <[email protected]> Co-authored-by: Brad White <[email protected]> Co-authored-by: Brad White <[email protected]> (cherry picked from commit e84742d)
delanni
added
backport
chore
Team:Operations
Team label for Operations Team
release_note:skip
Skip the PR/issue when compiling release notes
backport:skip
This commit does not require backporting
v8.10.3
labels
Sep 29, 2023
Pinging @elastic/kibana-operations (Team:Operations) |
@elasticmachine merge upstream |
…s in tsconfig to avoid outside-of-project ref errors
Ikuni17
approved these changes
Sep 29, 2023
@elasticmachine merge upstream |
@elasticmachine merge upstream |
@elasticmachine merge upstream |
💔 Build FailedFailed CI Steps
Metrics [docs]Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport:skip
This commit does not require backporting
backport
chore
release_note:skip
Skip the PR/issue when compiling release notes
Team:Operations
Team label for Operations Team
v8.10.3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #167428
Replaces: #167581
Part of: #167373
The osquery-cypress package was referring to configurations from a parent folder. This caused difficulties with having to exclude/include the same files in the
tsconfig.json
s, leading to hard-to-resolve typescript issues.This PR moves the configs in, and cleans up redundancies and type errors.
chore(osquery): move osquery/cypress configs to cypress folder, fix type errors
Co-authored-by: Patryk Kopyciński [email protected]
Co-authored-by: Brad White [email protected]
Co-authored-by: Brad White [email protected]
(cherry picked from commit e84742d)