Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.10][Osquery] Backport of Move Osquery/cypress configurations close to cypress (#167428) #167614

Merged
merged 9 commits into from
Oct 2, 2023

Conversation

delanni
Copy link
Contributor

@delanni delanni commented Sep 29, 2023

Backport of #167428

Replaces: #167581

Part of: #167373


The osquery-cypress package was referring to configurations from a parent folder. This caused difficulties with having to exclude/include the same files in the tsconfig.jsons, leading to hard-to-resolve typescript issues.

This PR moves the configs in, and cleans up redundancies and type errors.

chore(osquery): move osquery/cypress configs to cypress folder, fix type errors


Co-authored-by: Patryk Kopyciński [email protected]
Co-authored-by: Brad White [email protected]
Co-authored-by: Brad White [email protected]
(cherry picked from commit e84742d)

…lastic#167428)

The osquery-cypress package was referring to configurations from a
parent folder. This caused difficulties with having to exclude/include
the same files in the `tsconfig.json`s, leading to hard-to-resolve
typescript issues.

This PR moves the configs in, and cleans up redundancies and type
errors.

chore(osquery): move osquery/cypress configs to cypress folder, fix type
errors

---------

Co-authored-by: Patryk Kopyciński <[email protected]>
Co-authored-by: Brad White <[email protected]>
Co-authored-by: Brad White <[email protected]>
(cherry picked from commit e84742d)
@delanni delanni added backport chore Team:Operations Team label for Operations Team release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting v8.10.3 labels Sep 29, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

@delanni
Copy link
Contributor Author

delanni commented Sep 29, 2023

@elasticmachine merge upstream

@delanni
Copy link
Contributor Author

delanni commented Sep 30, 2023

@elasticmachine merge upstream

@delanni
Copy link
Contributor Author

delanni commented Oct 2, 2023

@elasticmachine merge upstream

@delanni
Copy link
Contributor Author

delanni commented Oct 2, 2023

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

kibana-ci commented Oct 2, 2023

💔 Build Failed

Failed CI Steps

Metrics [docs]

Unknown metric groups

ESLint disabled line counts

id before after diff
osquery 115 113 -2
securitySolution 448 445 -3
total -5

Total ESLint disabled count

id before after diff
osquery 116 114 -2
securitySolution 514 511 -3
total -5

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@delanni delanni merged commit cdd000c into elastic:8.10 Oct 2, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting backport chore release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team v8.10.3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants