Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Logs onboarding] Explore logs button should have different states #167409

Conversation

yngrdyn
Copy link
Contributor

@yngrdyn yngrdyn commented Sep 27, 2023

Closes #166009.

When system integration is installed successfully we should be able to redirect the user to logs explorer with the System integration selected

Screen.Recording.2023-09-27.at.20.23.51.mov

When system integration installation failed we should be able to redirect the user to logs explorer with All logs selected

Screen.Recording.2023-09-27.at.20.26.43.mov

When system integration is being installed, Explore Logs button should be disabled

Screen.Recording.2023-09-27.at.20.28.29.mov

How to test

  1. Log in as viewer user
  2. Enter system logs onboarding flow
  3. Verify System integration was not installed
  4. Click on Explore Logs
  5. Verify you are being redirected to Log explorer with All logs being selected
  6. Logout and log in again as admin user
  7. Enter system logs onboarding flow
  8. Verify system integration was installed successfully
  9. Click on Explore Logs
  10. Verify you are being redirected to Log explorer with [system] being selected

@yngrdyn yngrdyn requested a review from a team as a code owner September 27, 2023 13:56
@yngrdyn yngrdyn added the release_note:skip Skip the PR/issue when compiling release notes label Sep 27, 2023
@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • /oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@yngrdyn yngrdyn changed the title 166009 logs onboarding explore logs button should have different states [Logs onboarding] Explore logs button should have different states Sep 27, 2023
@yngrdyn
Copy link
Contributor Author

yngrdyn commented Sep 29, 2023

/oblt-deploy

@kuisathaverat
Copy link
Contributor

/oblt-deploy

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #2 / saved objects tagging - functional tests edit tag allows to edit the tag once the errors are fixed

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
observabilityOnboarding 239.4KB 239.6KB +224.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
observabilityOnboarding 5.5KB 5.6KB +59.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

async function onContinue() {
if (systemIntegrationStatus === 'rejected') {
await allDataSetsLocator!.navigate({});
Copy link
Contributor

@kpatticha kpatticha Oct 2, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this needed? 🤔

got it

Copy link
Contributor

@kpatticha kpatticha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yngrdyn yngrdyn merged commit 45771ff into elastic:main Oct 2, 2023
@kibanamachine kibanamachine added v8.11.0 backport:skip This commit does not require backporting labels Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes v8.11.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Logs onboarding] Explore logs button should have different states
6 participants