-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Logs onboarding] Explore logs button should have different states #167409
[Logs onboarding] Explore logs button should have different states #167409
Conversation
…g-explore-logs-button-should-have-different-states
…g-explore-logs-button-should-have-different-states
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
…hould-have-different-states
…hould-have-different-states
…hould-have-different-states
/oblt-deploy |
…hould-have-different-states
/oblt-deploy |
…hould-have-different-states
…hould-have-different-states
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
async function onContinue() { | ||
if (systemIntegrationStatus === 'rejected') { | ||
await allDataSetsLocator!.navigate({}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is this needed? 🤔
got it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Closes #166009.
When system integration is installed successfully we should be able to redirect the user to logs explorer with the
System integration
selectedScreen.Recording.2023-09-27.at.20.23.51.mov
When system integration installation failed we should be able to redirect the user to logs explorer with
All logs
selectedScreen.Recording.2023-09-27.at.20.26.43.mov
When system integration is being installed, Explore Logs button should be disabled
Screen.Recording.2023-09-27.at.20.28.29.mov
How to test
viewer
userExplore Logs
All logs
being selectedadmin
userExplore Logs
[system]
being selected