[Security Solution] expandable flyout - increase line-height for session preview #166932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PhilippeOberti
added
release_note:fix
Team:Threat Hunting:Investigations
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
To update your PR or re-run it, just comment with: |
christineweng
approved these changes
Sep 21, 2023
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
PhilippeOberti
added a commit
to PhilippeOberti/kibana
that referenced
this pull request
Sep 27, 2023
…ion preview (elastic#166932) (cherry picked from commit 416dabf) # Conflicts: # x-pack/plugins/security_solution/public/flyout/right/components/session_preview.tsx
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
PhilippeOberti
added a commit
that referenced
this pull request
Sep 27, 2023
…or session preview (#166932) (#167415) # Backport This will backport the following commits from `main` to `8.10`: - [[Security Solution] expandable flyout - increase line-height for session preview (#166932)](#166932) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Philippe Oberti","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-09-22T06:47:33Z","message":"[Security Solution] expandable flyout - increase line-height for session preview (#166932)","sha":"416dabf505e8cf2941ae8dd6187af707cfac68a6","branchLabelMapping":{"^v8.11.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:Threat Hunting:Investigations","v8.11.0","v8.10.3"],"number":166932,"url":"https://github.com/elastic/kibana/pull/166932","mergeCommit":{"message":"[Security Solution] expandable flyout - increase line-height for session preview (#166932)","sha":"416dabf505e8cf2941ae8dd6187af707cfac68a6"}},"sourceBranch":"main","suggestedTargetBranches":["8.10"],"targetPullRequestStates":[{"branch":"main","label":"v8.11.0","labelRegex":"^v8.11.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/166932","number":166932,"mergeCommit":{"message":"[Security Solution] expandable flyout - increase line-height for session preview (#166932)","sha":"416dabf505e8cf2941ae8dd6187af707cfac68a6"}},{"branch":"8.10","label":"v8.10.3","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Kibana Machine <[email protected]>
This was referenced Oct 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a very small UI issue visible in some scenarios where the Security Solution expandable flyout right panel session preview component has its row overlapping.
I could not really reproduce the issue locally to the extend of the screenshot found in the ticket. As you can see in the screenhost below, the rendering seems correct, but on the limit.
The
line-height :1.25could have worked but using1.5is safer and will work in more scenarios.https://github.com/elastic/security-team/issues/7665