[Serverless Search] Fix broken API key page #166368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TattdCodeMonkey
approved these changes
Sep 13, 2023
| @@ -49,7 +49,7 @@ export const ApiKeyPanel = ({ setClientApiKey }: { setClientApiKey: (value: stri | |||
| <CreateApiKeyFlyout | |||
| onClose={() => setIsFlyoutOpen(false)} | |||
| setApiKey={saveApiKey} | |||
| username={userProfile.user.full_name || userProfile.user.username} | |||
| username={user?.full_name || user?.username || ''} | |||
There was a problem hiding this comment.
This LGTM, from looking at the code we only use this username for display on the form so I think everything should still work even is user === undefined right?
💚 Build Succeeded
Metrics [docs]Async chunks
To update your PR or re-run it, just comment with: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This fixes the create API key flow being broken due to an undefined user profile.