Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EDR Workflows] Change grepFilter destructuring #166254

Merged
merged 4 commits into from
Sep 14, 2023
Merged

[EDR Workflows] Change grepFilter destructuring #166254

merged 4 commits into from
Sep 14, 2023

Conversation

tomsonpl
Copy link
Contributor

@tomsonpl tomsonpl commented Sep 12, 2023 •
edited
Loading

Apparently not every config contains env , therefore it crashed on destructuring.

@tomsonpl tomsonpl added chore release_note:skip Skip the PR/issue when compiling release notes v8.11.0 labels Sep 12, 2023
@tomsonpl tomsonpl self-assigned this Sep 12, 2023
paul-tavares
paul-tavares approved these changes Sep 12, 2023
View reviewed changes
Copy link
Contributor

@paul-tavares paul-tavares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 it

maximpn
maximpn approved these changes Sep 12, 2023
View reviewed changes
Copy link
Contributor

@maximpn maximpn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tomsonpl the fix LGTM.

It'd be great to know why env isn't set sometimes. I've noticed Osquery Cypress tests don't have configured reports, don't think it causes the issue but it's definitely some difference in the configuration.

@tomsonpl
Copy link
Contributor Author

@maximpn all the tests run in the pipeline have env and it worked fine. But today, we unskipped Defend Workflows Serverless job and apparently it didn't have env so this change is just a precaution :)

banderror
banderror approved these changes Sep 13, 2023
View reviewed changes
Copy link
Contributor

@banderror banderror left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @tomsonpl 👍

@tomsonpl tomsonpl enabled auto-merge (squash) September 14, 2023 20:31
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #25 / serverless security UI Create Case "before each" hook for "creates a case"

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @tomsonpl

@tomsonpl tomsonpl merged commit df99636 into elastic:main Sep 14, 2023
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paul-tavares paul-tavares paul-tavares approved these changes

@banderror banderror banderror approved these changes

@maximpn maximpn maximpn approved these changes

@MadameSheema MadameSheema Awaiting requested review from MadameSheema

@patrykkopycinski patrykkopycinski Awaiting requested review from patrykkopycinski

@oatkiller oatkiller Awaiting requested review from oatkiller

Assignees

@tomsonpl tomsonpl

Labels
backport:skip This commit does not require backporting chore release_note:skip Skip the PR/issue when compiling release notes v8.11.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@tomsonpl @kibana-ci @maximpn @banderror @paul-tavares @kibanamachine