Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[plugin-helpers] update readme #16616

Merged
merged 3 commits into from
Feb 8, 2018

Conversation

spalger
Copy link
Contributor

@spalger spalger commented Feb 8, 2018

Now that the plugin-helpers are a part of the Kibana repo some doc changes are necessary.

@spalger spalger added blocked Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v7.0.0 v6.3.0 labels Feb 8, 2018
@spalger spalger force-pushed the fixup/plugin-helpers-readme branch from 5c380ac to a698b79 Compare February 8, 2018 19:50
@spalger spalger added review and removed blocked labels Feb 8, 2018
@elasticmachine
Copy link
Contributor

💔 Build Failed

@spalger
Copy link
Contributor Author

spalger commented Feb 8, 2018

jenkins, test this

7.x | 4.6.x to 6.x (node 6+ only)
6.x | 4.6.x to 6.x
5.x | 4.x
The plugins helpers in the Kibana repo are available for Kibana 6.3 and greater. Just checkout the branch of Kibana you want to build against and the plugin helpers should be up to date for that version of Kibana.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also link to @elastic/plugin-helpers for <=6.2?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose

Copy link
Contributor

@kimjoar kimjoar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just that one question, otherwise LGTM

@spalger spalger merged commit a512466 into elastic:master Feb 8, 2018
spalger added a commit to spalger/kibana that referenced this pull request Feb 8, 2018
* [plugin-helpers] update the readme to describe changes now that it is in the Kibana repo

* [plugin-helpers/readme] add note about versions before 6.3
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

spalger added a commit that referenced this pull request Feb 10, 2018
* [plugin-helpers] update the readme to describe changes now that it is in the Kibana repo

* [plugin-helpers/readme] add note about versions before 6.3
@spalger
Copy link
Contributor Author

spalger commented Feb 10, 2018

6.x/6.3: 65fefe4

@spalger spalger deleted the fixup/plugin-helpers-readme branch February 10, 2018 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v6.3.0 v7.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants