[maps] fix Air-gapped enviroment hitting 400 error loading fonts for layer #165986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
nreese
added
release_note:fix
Team:Presentation
|
Pinging @elastic/kibana-presentation (Team:Presentation) |
nickpeihl
approved these changes
Sep 13, 2023
jbudz
approved these changes
Sep 13, 2023
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Sep 13, 2023
…layer (elastic#165986) Closes elastic#165974 The root cause of the problem is calling `basePath.prepend` on a path without a leading `/`. Maps is not consistent with path constants. Some have leading `/` while others do not. To resolve the issue, this PR updates all path constants to consistently have leading `/`. PR adds functional test runner with `map.includeElasticMapsService: false` to ensure maps is tested without EMS enabled to catch future regressions. ### Test instructions * set *map.includeElasticMapsService: false* in kibana.dev.yml * install sample data set * create new map with documents layer * Configure label styling * Verify layer is displayed with labels <img width="500" alt="Screen Shot 2023-09-13 at 6 26 23 AM" src="https://github.com/elastic/kibana/assets/373691/44d12e87-9b80-424c-9bc9-126b373bdf18"> --------- Co-authored-by: kibanamachine <[email protected]> (cherry picked from commit 691311c)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Sep 13, 2023
…ts for layer (#165986) (#166375) # Backport This will backport the following commits from `main` to `8.10`: - [[maps] fix Air-gapped enviroment hitting 400 error loading fonts for layer (#165986)](#165986) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Nathan Reese","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-09-13T16:06:05Z","message":"[maps] fix Air-gapped enviroment hitting 400 error loading fonts for layer (#165986)\n\nCloses https://github.com/elastic/kibana/issues/165974\r\n\r\nThe root cause of the problem is calling `basePath.prepend` on a path\r\nwithout a leading `/`. Maps is not consistent with path constants. Some\r\nhave leading `/` while others do not. To resolve the issue, this PR\r\nupdates all path constants to consistently have leading `/`.\r\n\r\nPR adds functional test runner with `map.includeElasticMapsService:\r\nfalse` to ensure maps is tested without EMS enabled to catch future\r\nregressions.\r\n\r\n### Test instructions\r\n* set *map.includeElasticMapsService: false* in kibana.dev.yml\r\n* install sample data set\r\n* create new map with documents layer\r\n* Configure label styling\r\n* Verify layer is displayed with labels\r\n\r\n<img width=\"500\" alt=\"Screen Shot 2023-09-13 at 6 26 23 AM\"\r\nsrc=\"https://github.com/elastic/kibana/assets/373691/44d12e87-9b80-424c-9bc9-126b373bdf18\">\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"691311ce7c38cff3ca89758f1a45e31b7f292759","branchLabelMapping":{"^v8.11.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:Presentation","Feature:Maps","v8.11.0","v8.10.1"],"number":165986,"url":"https://github.com/elastic/kibana/pull/165986","mergeCommit":{"message":"[maps] fix Air-gapped enviroment hitting 400 error loading fonts for layer (#165986)\n\nCloses https://github.com/elastic/kibana/issues/165974\r\n\r\nThe root cause of the problem is calling `basePath.prepend` on a path\r\nwithout a leading `/`. Maps is not consistent with path constants. Some\r\nhave leading `/` while others do not. To resolve the issue, this PR\r\nupdates all path constants to consistently have leading `/`.\r\n\r\nPR adds functional test runner with `map.includeElasticMapsService:\r\nfalse` to ensure maps is tested without EMS enabled to catch future\r\nregressions.\r\n\r\n### Test instructions\r\n* set *map.includeElasticMapsService: false* in kibana.dev.yml\r\n* install sample data set\r\n* create new map with documents layer\r\n* Configure label styling\r\n* Verify layer is displayed with labels\r\n\r\n<img width=\"500\" alt=\"Screen Shot 2023-09-13 at 6 26 23 AM\"\r\nsrc=\"https://github.com/elastic/kibana/assets/373691/44d12e87-9b80-424c-9bc9-126b373bdf18\">\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"691311ce7c38cff3ca89758f1a45e31b7f292759"}},"sourceBranch":"main","suggestedTargetBranches":["8.10"],"targetPullRequestStates":[{"branch":"main","label":"v8.11.0","labelRegex":"^v8.11.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/165986","number":165986,"mergeCommit":{"message":"[maps] fix Air-gapped enviroment hitting 400 error loading fonts for layer (#165986)\n\nCloses https://github.com/elastic/kibana/issues/165974\r\n\r\nThe root cause of the problem is calling `basePath.prepend` on a path\r\nwithout a leading `/`. Maps is not consistent with path constants. Some\r\nhave leading `/` while others do not. To resolve the issue, this PR\r\nupdates all path constants to consistently have leading `/`.\r\n\r\nPR adds functional test runner with `map.includeElasticMapsService:\r\nfalse` to ensure maps is tested without EMS enabled to catch future\r\nregressions.\r\n\r\n### Test instructions\r\n* set *map.includeElasticMapsService: false* in kibana.dev.yml\r\n* install sample data set\r\n* create new map with documents layer\r\n* Configure label styling\r\n* Verify layer is displayed with labels\r\n\r\n<img width=\"500\" alt=\"Screen Shot 2023-09-13 at 6 26 23 AM\"\r\nsrc=\"https://github.com/elastic/kibana/assets/373691/44d12e87-9b80-424c-9bc9-126b373bdf18\">\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"691311ce7c38cff3ca89758f1a45e31b7f292759"}},{"branch":"8.10","label":"v8.10.1","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Nathan Reese <[email protected]>
This was referenced Oct 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #165974
The root cause of the problem is calling
basePath.prependon a path without a leading/. Maps is not consistent with path constants. Some have leading/while others do not. To resolve the issue, this PR updates all path constants to consistently have leading/.PR adds functional test runner with
map.includeElasticMapsService: falseto ensure maps is tested without EMS enabled to catch future regressions.Test instructions