-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Search] Update connector also updates status #165983
Merged
sphilipse
merged 1 commit into
elastic:main
from
sphilipse:search-convert-connector-status
Sep 8, 2023
Merged
[Search] Update connector also updates status #165983
sphilipse
merged 1 commit into
elastic:main
from
sphilipse:search-convert-connector-status
Sep 8, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sphilipse
added
release_note:skip
Skip the PR/issue when compiling release notes
Team:EnterpriseSearch
v8.11.0
labels
Sep 7, 2023
efegurkan
approved these changes
Sep 8, 2023
💔 All backports failed
Manual backportTo create the backport manually run:
Questions ?Please refer to the Backport tool documentation |
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
sphilipse
added a commit
to sphilipse/kibana
that referenced
this pull request
Sep 8, 2023
## Summary Converting a connector from native to client now updates the connector status. (cherry picked from commit 9deae84) # Conflicts: # packages/kbn-search-connectors/lib/update_native.ts
sphilipse
added a commit
that referenced
this pull request
Sep 8, 2023
# Backport This will backport the following commits from `main` to `8.10`: - [[Search] Update connector also updates status (#165983)](#165983) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Sander Philipse","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-09-08T09:14:17Z","message":"[Search] Update connector also updates status (#165983)\n\n## Summary\r\n\r\nConverting a connector from native to client now updates the connector\r\nstatus.","sha":"9deae84801fa770a41d107c633d3b6e356631b03","branchLabelMapping":{"^v8.11.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:EnterpriseSearch","v8.10.0","v8.11.0"],"number":165983,"url":"https://github.com/elastic/kibana/pull/165983","mergeCommit":{"message":"[Search] Update connector also updates status (#165983)\n\n## Summary\r\n\r\nConverting a connector from native to client now updates the connector\r\nstatus.","sha":"9deae84801fa770a41d107c633d3b6e356631b03"}},"sourceBranch":"main","suggestedTargetBranches":["8.10"],"targetPullRequestStates":[{"branch":"8.10","label":"v8.10.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.11.0","labelRegex":"^v8.11.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/165983","number":165983,"mergeCommit":{"message":"[Search] Update connector also updates status (#165983)\n\n## Summary\r\n\r\nConverting a connector from native to client now updates the connector\r\nstatus.","sha":"9deae84801fa770a41d107c633d3b6e356631b03"}}]}] BACKPORT-->
This was referenced Oct 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
release_note:skip
Skip the PR/issue when compiling release notes
Team:EnterpriseSearch
v8.10.0
v8.11.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Converting a connector from native to client now updates the connector status.