[Cloud Security][Telemetry] add error handling incase an individual collector fails

[Omolola-Akinleye]

Summary

Summarize your PR. If it involves visual changes include a screenshot or gif.
The kibana cloud security usage collector payload fails when one feature collector fails. I applied error handling and enabled the feature collector to fail gracefully with a default value. We are now using Promise.allSettled vs Promse.all to avoid all collectors failing in case one collector fails.

[elasticmachine]

Pinging @elastic/kibana-cloud-security-posture (Team:Cloud Security)

[kfirpeled]

here if there's an error you would do something like:

const accountsStats = handleResult('Accounts', results[1]) || []

[Omolola-Akinleye]

Promise.allSettled() always resolves in a truthy value - an object so I would never render a [].

 // [
//   { status: 'fulfilled', value: 33 },
//   { status: 'fulfilled', value: 66 },
//   { status: 'fulfilled', value: 99 },
//   { status: 'rejected', reason: Error: an error }
// ] ```

[kfirpeled]

nit: we are not handling the error here (I don't see logging as handling it) so I'd suggest name that suggests the actual action when the happy flow happens like extractPromiseValue

[kfirpeled]

From what I've read about never it doesn't appear to be related here

my reference: https://www.typescriptlang.org/docs/handbook/basic-types.html#never

[Omolola-Akinleye]

Okay, good point. I mistakenly thought we wanted to handle the error with an empty state so applying never fixed the issue type error but I'll change the default value to undefined.

[kfirpeled]

LGTM - added a nit refactoring suggestion

[kfirpeled]

nit you could improve it a bit by not tangling yourself with results[X] and working with it by using the following changing getPromiseValue to receive a promise and wait for it
So when forming the allSettled request, the naming of the request is right next to it.
And now getPromiseValue name also describes better its logic.
And maybe awaitPromiseSafe describes it even better. It is safe because it won't throw any errors

      const awaitPromiseSafe = async <T>(
        taskName: CloudSecurityUsageCollectorType,
        promise: Promise<T>
      ) => {
        try {
          const val = await promise;
          return val;
        } catch (error) {
          logger.error(`${taskName} task failed: ${error.message}`);
          logger.error(error.stack);
          return undefined;
        }
      };
      const esClient = collectorFetchContext.esClient;
      const soClient = collectorFetchContext.soClient;
      const [
        indices,
        // eslint-disable-next-line @typescript-eslint/naming-convention
        accounts_stats,
        // eslint-disable-next-line @typescript-eslint/naming-convention
        resources_stats,
        // eslint-disable-next-line @typescript-eslint/naming-convention
        rules_stats,
        // eslint-disable-next-line @typescript-eslint/naming-convention
        installation_stats,
        // eslint-disable-next-line @typescript-eslint/naming-convention
        alerts_stats,
      ] = await Promise.all([
        awaitPromiseSafe('Indices', getIndicesStats(esClient, soClient, coreServices, logger)),
        awaitPromiseSafe('Accounts', getAccountsStats(esClient, logger)),
        awaitPromiseSafe('Resources', getResourcesStats(esClient, logger)),
        awaitPromiseSafe('Rules', getRulesStats(esClient, logger)),
        awaitPromiseSafe(
          'Installation',
          getInstallationStats(esClient, soClient, coreServices, logger)
        ),
        awaitPromiseSafe('Alerts', getAlertsStats(esClient, logger)),
      ]);

      return {
        indices,
        accounts_stats,
        resources_stats,
        rules_stats,
        installation_stats,
        alerts_stats,
      };

[kfirpeled]

and we can replace allSettled with all, because we wrap it with a handler that keeps it safe

[kibana-ci]

💚 Build Succeeded

• Buildkite Build
• Commit: 08c0921

Metrics [docs]

✅ unchanged

History

• 💔 Build #158616 failed 73531f6
• 💔 Build #158036 failed 421a4f3
• 💔 Build #157923 failed 283bd81
• 💔 Build #157182 failed e97c821
• 💔 Build #156999 failed 21ba89e

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @Omolola-Akinleye

[kfirpeled]

💯