[Security Solution] Prevent junit tranformation command from breaking a build step #165824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maximpn
added
release_note:skip
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
|
@elastic/kibana-operations Can we merge this PR? |
|
@maximpn The osquery and defend workflows tests have been adjusted. We shouldn't be blocking you any more 👍 |
jbudz
reviewed
Sep 6, 2023
maximpn
force-pushed
the
prevent-junit-merge-failure
branch
from
7708e65 to
a58ba36
Compare
|
@jbudz I rebased the PR. @PhilippeOberti should take care of Threat Intelligence Cypress tests during this week. |
💔 Build FailedFailed CI Steps
Test Failures
Metrics [docs]
History
To update your PR or re-run it, just comment with: cc @maximpn |
mistic
added a commit
that referenced
this pull request
Sep 7, 2023
…te (#165929) ## Summary Fixes failed build steps when there are no tests to execute and hence no reports. ## Details Despite this [PR](#165824) fixes tests failure when there are no reports but `yarn junit:merge` tries to convert them to junit format the problem is partially stays as `Failed Test Reporter` runs for every build step meaning also for successful build steps. We don't need to handle failed test reports for successful build steps. There are cases when there are no tests to run so Cypress doesn't produce reports and nothing is converted to junit format so `Failed Test Reporter` fails and causes a build step to fails. It could be solved by defining an environment variable `DISABLE_MISSING_TEST_REPORT_ERRORS=true` but we need to make sure reports exist for failed tests. Taking this into account we can rely on `BUILDKITE_COMMAND_EXIT_STATUS` to avoid running `Failed Test Reporter` if the build step successed. One may ask why don't skip `Upload Artifacts` too. We may need some build artifacts for successful build steps. --------- Co-authored-by: Tiago Costa <[email protected]>
banderror
pushed a commit
to banderror/kibana
that referenced
this pull request
Sep 25, 2023
…te (elastic#165929) ## Summary Fixes failed build steps when there are no tests to execute and hence no reports. ## Details Despite this [PR](elastic#165824) fixes tests failure when there are no reports but `yarn junit:merge` tries to convert them to junit format the problem is partially stays as `Failed Test Reporter` runs for every build step meaning also for successful build steps. We don't need to handle failed test reports for successful build steps. There are cases when there are no tests to run so Cypress doesn't produce reports and nothing is converted to junit format so `Failed Test Reporter` fails and causes a build step to fails. It could be solved by defining an environment variable `DISABLE_MISSING_TEST_REPORT_ERRORS=true` but we need to make sure reports exist for failed tests. Taking this into account we can rely on `BUILDKITE_COMMAND_EXIT_STATUS` to avoid running `Failed Test Reporter` if the build step successed. One may ask why don't skip `Upload Artifacts` too. We may need some build artifacts for successful build steps. --------- Co-authored-by: Tiago Costa <[email protected]> (cherry picked from commit 369d2fe)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements a temporary fix to prevent
yarn junit:mergecommand from breaking a build step by returning non zero code.yarn junit:mergefails in case if it can't find reports or folders it operates on weren't created beforehand.