Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Observability AI Assistant] Use POST for get_apm_services_list #165621

Merged
merged 1 commit into from
Sep 4, 2023
Merged

[Observability AI Assistant] Use POST for get_apm_services_list #165621

merged 1 commit into from
Sep 4, 2023

Conversation

CoenWarmer
Copy link
Contributor

@CoenWarmer CoenWarmer commented Sep 4, 2023 •
edited by kibanamachine
Loading

Summary

Does what it says on the tin

@CoenWarmer CoenWarmer requested review from a team as code owners September 4, 2023 17:15
@botelastic botelastic bot added the Team:APM All issues that need APM UI Team support label Sep 4, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:APM)

@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • /oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@CoenWarmer CoenWarmer added release_note:skip Skip the PR/issue when compiling release notes backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) v8.10.0 v8.11.0 labels Sep 4, 2023
@CoenWarmer CoenWarmer enabled auto-merge (squash) September 4, 2023 17:16
@kibana-ci
Copy link
Collaborator

kibana-ci commented Sep 4, 2023 •
edited
Loading

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] Serverless Security Examples Tests / serverless examples UI Search examples handling warnings with search source fetch shows shard failure warning notifications by default

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
observabilityAIAssistant 178.0KB 178.2KB +142.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@CoenWarmer CoenWarmer merged commit 300e298 into elastic:main Sep 4, 2023
@kibanamachine kibanamachine mentioned this pull request Sep 4, 2023
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.10

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Sep 4, 2023
@CoenWarmer
[Observability AI Assistant] Use POST for get_apm_services_list (elas…
2483e86 
…tic#165621)

Co-authored-by: Dario Gieselaar <[email protected]>
(cherry picked from commit 300e298)
kibanamachine added a commit that referenced this pull request Sep 4, 2023
@kibanamachine @CoenWarmer
[8.10] [Observability AI Assistant] Use POST for get_apm_services_list (
913dd8b 
#165621) (#165628)

# Backport

This will backport the following commits from `main` to `8.10`:
- [[Observability AI Assistant] Use POST for get_apm_services_list
(#165621)](#165621)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Coen
Warmer","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-09-04T18:18:58Z","message":"[Observability
AI Assistant] Use POST for get_apm_services_list
(#165621)\n\nCo-authored-by: Dario Gieselaar
<[email protected]>","sha":"300e2985c18498e35b2b82cd88c86459471beed3","branchLabelMapping":{"^v8.11.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:APM","release_note:skip","backport:prev-minor","v8.10.0","v8.11.0"],"number":165621,"url":"https://github.com/elastic/kibana/pull/165621","mergeCommit":{"message":"[Observability
AI Assistant] Use POST for get_apm_services_list
(#165621)\n\nCo-authored-by: Dario Gieselaar
<[email protected]>","sha":"300e2985c18498e35b2b82cd88c86459471beed3"}},"sourceBranch":"main","suggestedTargetBranches":["8.10"],"targetPullRequestStates":[{"branch":"8.10","label":"v8.10.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.11.0","labelRegex":"^v8.11.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/165621","number":165621,"mergeCommit":{"message":"[Observability
AI Assistant] Use POST for get_apm_services_list
(#165621)\n\nCo-authored-by: Dario Gieselaar
<[email protected]>","sha":"300e2985c18498e35b2b82cd88c86459471beed3"}}]}]
BACKPORT-->

Co-authored-by: Coen Warmer <[email protected]>
@dgieselaar dgieselaar deleted the obs-ai-assistant-apm-post-services-list branch September 5, 2023 05:24
This was referenced Oct 1, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgieselaar dgieselaar dgieselaar approved these changes

Assignees
No one assigned
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) release_note:skip Skip the PR/issue when compiling release notes Team:APM All issues that need APM UI Team support v8.10.0 v8.11.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@CoenWarmer @elasticmachine @apmmachine @kibana-ci @kibanamachine @dgieselaar