ES|QL wrap with pipes #165598
Merged
ES|QL wrap with pipes #165598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stratoula
added
release_note:skip
stratoula
added
Team:Visualizations
|
Pinging @elastic/kibana-visualizations (Team:Visualizations) |
dej611
approved these changes
Sep 5, 2023
| const codeNoLines = pipes?.map((pipe) => { | ||
| return pipe.replaceAll('\n', ''); | ||
| }); | ||
| return codeNoLines.join(isWrapped ? '|' : '\n|'); |
There was a problem hiding this comment.
Should it trim the text before each pipe?
💔 Build FailedFailed CI Steps
Test Failures
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Atm the wrap button is not very useful on the extended mode of the ES|QL editor. We would like to give the user the ability to wrap/unwrap based on the pipes.
Checklist