Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Ops] Run kibana quality gate suites #165346
[Ops] Run kibana quality gate suites #165346
Changes from 8 commits
374dd29
ca1e48f
5700043
4aaa821
15267d7
082e40b
a7b4ebe
c2f2c69
695ae9d
2beebb0
7089ff6
538aa06
b885d4f
5cf434b
6d3e815
739e338
8aeb4b8
ee8e3fb
f899e91
b075ba0
04261af
c9e7fa7
ecd6beb
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really appreciate the URL to the Buildkite pipeline - very user friendly 💯
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By the way, I just noticed that all files and folders in the
.buildkite/pipelines
directory use underscore as word separators, except forquality-gates
and its files 🙂There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it was a guest appearance from a non-kibana team, I guess they brought practise that they had everywhere else.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, not a big deal. Dashes vs. underscores is something that has always caught my eye for some unknown reason...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
high pattern recognition, I'm also bothered by it :D I'll change this once serverless releases are smooth