Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ops] Run kibana quality gate suites #165346

Merged
merged 23 commits into from
Sep 6, 2023
Merged

[Ops] Run kibana quality gate suites #165346

Show file tree
Hide file tree
Changes from 20 commits
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
374dd29
chore(quality-gates): trigger downstream test pipelines from quality-…
delanni Aug 23, 2023
ca1e48f
chore(quality-gates): move pipeline head file to .buildkite/ where th…
delanni Aug 23, 2023
5700043
chore(quality-gates): remove name property from build
delanni Aug 23, 2023
4aaa821
chore(quality-gates): Add quality gates for staging, add baking periods
delanni Aug 24, 2023
15267d7
chore(quality-gates): move kibana-tests head file to original slot
delanni Aug 25, 2023
082e40b
chore(quality-gates): Remove name params from trigger steps
delanni Aug 29, 2023
a7b4ebe
chore(quality-gates): add fleet test job, add build links
delanni Aug 30, 2023
c2f2c69
chore(quality-gates): Add security solutions qg pipeline script stub
delanni Aug 31, 2023
695ae9d
Merge branch 'main' into run-kibana-quality-gate-suites
delanni Sep 4, 2023
2beebb0
chore(quality-gates): only run hooks when agent manager is kibana
delanni Sep 4, 2023
7089ff6
chore: remove 'build' props (they don't exist on command triggers)
delanni Sep 4, 2023
538aa06
chore(quality-gates): Remove uplicate skip instruction from pre_commands
delanni Sep 4, 2023
b885d4f
chore(quality-gates): Remove stub triggers from QA quality-gate job
delanni Sep 4, 2023
5cf434b
Merge branch 'main' into run-kibana-quality-gate-suites
delanni Sep 5, 2023
6d3e815
chore(quality-gates): Prevent verification (mostly because of notific…
delanni Sep 5, 2023
739e338
Merge branch 'main' into run-kibana-quality-gate-suites
mistic Sep 5, 2023
8aeb4b8
Merge branch 'main' into run-kibana-quality-gate-suites
mistic Sep 5, 2023
ee8e3fb
Merge branch 'main' into run-kibana-quality-gate-suites
mistic Sep 6, 2023
f899e91
chore(quality-gates): Add more build URLs, re-add env to message
delanni Sep 6, 2023
b075ba0
chore(quality-gates): Allow soft fails on some steps. We currently do…
delanni Sep 6, 2023
04261af
Merge branch 'main' into run-kibana-quality-gate-suites
Sep 6, 2023
c9e7fa7
chore(quality-gates): Remove unneeded soft-fail allowances
delanni Sep 6, 2023
ecd6beb
chore(quality-gates): Remove RAC load tests
delanni Sep 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .buildkite/pipelines/quality-gates/pipeline.kibana-tests.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ steps:
- label: ":pipeline::grey_question::seedling: Trigger Kibana Tests for ${ENVIRONMENT}"
env:
QG_PIPELINE_LOCATION: ".buildkite/pipelines/quality-gates"
command: "make -C /agent run-environment-tests"
command: "make -C /agent run-environment-tests" # will trigger https://buildkite.com/elastic/kibana-tests
agents:
image: "docker.elastic.co/ci-agent-images/quality-gate-seedling:0.0.2"

Expand Down
19 changes: 5 additions & 14 deletions .buildkite/pipelines/quality-gates/pipeline.tests-production.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,27 +3,18 @@
# A failure in this pipeline build will prevent further progression to the subsequent stage.

steps:
- label: ":pipeline::fleet::seedling: Trigger Observability Kibana Tests for ${ENVIRONMENT}"
command: echo "replace me with Observability specific Kibana tests"
agents:
image: "docker.elastic.co/ci-agent-images/basic-buildkite-agent:1688566364"

- label: ":pipeline::lock::seedling: Trigger Security Kibana Tests for ${ENVIRONMENT}"
command: echo "replace me with Security specific Kibana tests"
agents:
image: "docker.elastic.co/ci-agent-images/basic-buildkite-agent:1688566364"

- label: ":rocket: Run cp e2e tests"
trigger: "ess-k8s-production-e2e-tests"
- label: ":pipeline::rocket::seedling: Trigger control-plane e2e tests"
trigger: "ess-k8s-production-e2e-tests" # https://buildkite.com/elastic/ess-k8s-production-e2e-tests
build:
message: "${BUILDKITE_MESSAGE}"
env:
REGION_ID: aws-us-east-1
NAME_PREFIX: ci_test_${SERVICE}-promotion_
NAME_PREFIX: ci_test_kibana-promotion_
message: "${BUILDKITE_MESSAGE} (triggered by pipeline.tests-production.yaml)"

- wait: ~

- label: ":judge::seedling: Trigger Manual Tests Phase"
command: "make -C /agent trigger-manual-verification-phase"
if: build.branch == "main"
agents:
image: "docker.elastic.co/ci-agent-images/manual-verification-agent:0.0.2"
59 changes: 40 additions & 19 deletions .buildkite/pipelines/quality-gates/pipeline.tests-qa.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,37 +3,58 @@
# this pipeline build will prevent further progression to the subsequent stage.

steps:
- label: ":pipeline::kibana::seedling: Trigger Kibana Tests for ${ENVIRONMENT}"
command: echo "replace me with Kibana specific tests"
agents:
image: "docker.elastic.co/ci-agent-images/basic-buildkite-agent:1688566364"
- label: ":pipeline::kibana::seedling: Trigger Kibana Serverless Tests for ${ENVIRONMENT}"
trigger: appex-qa-kibana-serverless-ftr-tests # https://buildkite.com/elastic/appex-qa-kibana-serverless-ftr-tests
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really appreciate the URL to the Buildkite pipeline - very user friendly 💯

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By the way, I just noticed that all files and folders in the .buildkite/pipelines directory use underscore as word separators, except for quality-gates and its files 🙂

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it was a guest appearance from a non-kibana team, I guess they brought practise that they had everywhere else.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, not a big deal. Dashes vs. underscores is something that has always caught my eye for some unknown reason...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high pattern recognition, I'm also bothered by it :D I'll change this once serverless releases are smooth

soft_fail: true # Remove this before release or when tests stabilize
build:
env:
ENVIRONMENT: ${ENVIRONMENT}
message: "${BUILDKITE_MESSAGE} (triggered by pipeline.tests-qa.yaml)"

- label: ":pipeline::fleet::seedling: Trigger Fleet Kibana Tests for ${ENVIRONMENT}"
command: echo "replace me with Fleet specific Kibana tests"
agents:
image: "docker.elastic.co/ci-agent-images/basic-buildkite-agent:1688566364"
- label: ":pipeline::weight_lifter::seedling: Trigger RAC Alert Load tests for ${ENVIRONMENT}"
trigger: appex-qa-rac-alert-load # https://buildkite.com/elastic/appex-qa-rac-alert-load
soft_fail: true # Remove this before release or when tests stabilize
build:
env:
ENVIRONMENT: ${ENVIRONMENT}
SERVERLESS_ONLY: true
message: "${BUILDKITE_MESSAGE} (triggered by pipeline.tests-qa.yaml)"

- label: ":pipeline::lock::seedling: Trigger Security Kibana Tests for ${ENVIRONMENT}"
command: echo "replace me with Security specific Kibana tests"
agents:
image: "docker.elastic.co/ci-agent-images/basic-buildkite-agent:1688566364"
- group: ":female-detective: Security Solution Tests"
key: "security"
steps:
- label: ":pipeline::female-detective::seedling: Trigger Security Solution quality gate script"
command: .buildkite/scripts/pipelines/security_solution_quality_gate/pipeline.sh
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a placeholder file for now, but we may have to follow the trigger pattern in the future based on the pre-command/post-command skips.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I agree, having external pipelines are probably a lot better for us, especially because that can run in a Kibana-managed agent. Once the team finds time to work on these tests, we could move it to a separate pipeline.


- label: ":pipeline::lock::seedling: Trigger Control Plane Kibana Tests for ${ENVIRONMENT}"
command: echo "replace me with Control Plane specific Kibana tests"
agents:
image: "docker.elastic.co/ci-agent-images/basic-buildkite-agent:1688566364"
- label: ":judge::seedling: Trigger Manual Tests Phase"
command: "make -C /agent trigger-manual-verification-phase"
if: build.branch == "main"
env:
TEAM_CHANNEL: "#kibana-mission-control"
agents:
image: "docker.elastic.co/ci-agent-images/manual-verification-agent:0.0.2"

- label: ":pipeline::ship::seedling: Trigger Fleet serverless smoke tests for ${ENVIRONMENT}"
trigger: fleet-smoke-tests # https://buildkite.com/elastic/fleet-smoke-tests
soft_fail: true # Remove this before release or when tests stabilize
build:
env:
ENVIRONMENT: ${ENVIRONMENT}
message: "${BUILDKITE_MESSAGE} (triggered by pipeline.tests-qa.yaml)"

- label: ":rocket: Run cp e2e tests"
trigger: "ess-k8s-qa-e2e-tests-daily"
- label: ":pipeline::rocket::seedling: Trigger control-plane e2e tests"
trigger: "ess-k8s-qa-e2e-tests-daily" # https://buildkite.com/elastic/ess-k8s-qa-e2e-tests-daily
soft_fail: true # Remove this before release or when tests stabilize
watson marked this conversation as resolved.
Show resolved Hide resolved
build:
message: "${BUILDKITE_MESSAGE}"
env:
REGION_ID: aws-eu-west-1
NAME_PREFIX: ci_test_kibana-promotion_
message: "${BUILDKITE_MESSAGE} (triggered by pipeline.tests-qa.yaml)"

- wait: ~

- label: ":judge::seedling: Trigger Manual Tests Phase"
command: "make -C /agent trigger-manual-verification-phase"
if: build.branch == "main"
agents:
image: "docker.elastic.co/ci-agent-images/manual-verification-agent:0.0.2"
17 changes: 4 additions & 13 deletions .buildkite/pipelines/quality-gates/pipeline.tests-staging.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,27 +3,18 @@
# this pipeline build will prevent further progression to the subsequent stage.

steps:
- label: ":pipeline::fleet::seedling: Trigger Observability Kibana Tests for ${ENVIRONMENT}"
command: echo "replace me with Observability specific Kibana tests"
agents:
image: "docker.elastic.co/ci-agent-images/basic-buildkite-agent:1688566364"

- label: ":pipeline::lock::seedling: Trigger Security Kibana Tests for ${ENVIRONMENT}"
command: echo "replace me with Security specific Kibana tests"
agents:
image: "docker.elastic.co/ci-agent-images/basic-buildkite-agent:1688566364"

- label: ":rocket: Run cp e2e tests"
trigger: "ess-k8s-staging-e2e-tests"
- label: ":pipeline::rocket::seedling: Trigger control-plane e2e tests"
trigger: "ess-k8s-staging-e2e-tests" # https://buildkite.com/elastic/ess-k8s-staging-e2e-tests
build:
message: "${BUILDKITE_MESSAGE}"
env:
REGION_ID: aws-us-east-1
NAME_PREFIX: ci_test_kibana-promotion_
message: "${BUILDKITE_MESSAGE} (triggered by pipeline.tests-staging.yaml)"

- wait: ~

- label: ":judge::seedling: Trigger Manual Tests Phase"
command: "make -C /agent trigger-manual-verification-phase"
if: build.branch == "main"
agents:
image: "docker.elastic.co/ci-agent-images/manual-verification-agent:0.0.2"