Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Profiling] Remove deprecated methods #165282

Closed
wants to merge 7 commits into from

Conversation

jbcrail
Copy link
Contributor

@jbcrail jbcrail commented Aug 31, 2023

Summary

This PR removes several methods that are no longer used after migrating to the Elasticsearch plugin.

Removing these methods will also make #165198 and future refactoring easier.

For maintainers

@jbcrail jbcrail added release_note:skip Skip the PR/issue when compiling release notes v8.11.0 labels Aug 31, 2023
@jbcrail jbcrail requested a review from a team as a code owner August 31, 2023 00:04
@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • /oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
profiling 200 199 -1

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
profiling 19 17 -2

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
profiling 21.9KB 21.3KB -618.0B
Unknown metric groups

API count

id before after diff
profiling 19 17 -2

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@cauemarcondes cauemarcondes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jbcrail I'll make these changes myself directly in my PR if that's ok with you. There'll be too many merge conflicts if you merge this one in.

Done Here 46f7e3d

@jbcrail
Copy link
Contributor Author

jbcrail commented Sep 1, 2023

Thanks, sounds good. I'll close this now.

@jbcrail jbcrail closed this Sep 1, 2023
auto-merge was automatically disabled September 1, 2023 01:46

Pull request was closed

@jbcrail jbcrail deleted the profiling-rm-deprecated-methods branch September 1, 2023 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes v8.11.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants