Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] Migrate risk score internal APIs to versioned router #165280

Merged
merged 6 commits into from
Oct 2, 2023
Merged

[Security Solution] Migrate risk score internal APIs to versioned router #165280

merged 6 commits into from
Oct 2, 2023

Conversation

marshallmain
Copy link
Contributor

@marshallmain marshallmain added release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.11.0 labels Aug 31, 2023
@marshallmain marshallmain marked this pull request as ready for review August 31, 2023 14:52
@marshallmain marshallmain requested review from a team as code owners August 31, 2023 14:52
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

angorayc
angorayc reviewed Sep 25, 2023
View reviewed changes
Copy link
Contributor

@angorayc angorayc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've seen a different format of version before. The version I saw was more like a date, is the format of version different because of these are internal apis?

@marshallmain
Copy link
Contributor Author

I've seen a different format of version before. The version I saw was more like a date, is the format of version different because of these are internal apis?

Yeah, the guidance for internal APIs is different than for public APIs.

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #29 / dashboard app - group 6 dashboard snapshots compare controls snapshot in dark mode

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 13.0MB 13.0MB +38.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@marshallmain marshallmain merged commit 3f4e53f into elastic:main Oct 2, 2023
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Oct 2, 2023
@marshallmain marshallmain deleted the risk-score-versioned-router branch October 2, 2023 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@angorayc angorayc angorayc approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.11.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@marshallmain @elasticmachine @kibana-ci @angorayc @kibanamachine