Fix interactive Setup UI never reaches Finished state #165273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomheymann
added
Team:Security
|
Pinging @elastic/kibana-security (Team:Security) |
…com/thomheymann/kibana into fix-post-interactive-setup-redirect
thomheymann
commented
Aug 31, 2023
| @@ -13,6 +13,7 @@ export default function ({ loadTestFile }: FtrProviderContext) { | |||
| loadTestFile(require.resolve('./management')); | |||
|
|
|||
| // platform security | |||
| loadTestFile(require.resolve('./security/api_keys')); | |||
There was a problem hiding this comment.
This test suite was added as part of #164886 but was not referenced correctly so never got executed.
…t-interactive-setup-redirect
💚 Build Succeeded
Metrics [docs]Page load bundle
History
To update your PR or re-run it, just comment with: |
jeramysoucy
approved these changes
Aug 31, 2023
| @@ -13,6 +13,7 @@ export default function ({ loadTestFile }: FtrProviderContext) { | |||
| loadTestFile(require.resolve('./management')); | |||
|
|
|||
| // platform security | |||
| loadTestFile(require.resolve('./security/api_keys')); | |||
kibanamachine
added
v8.11.0
backport:skip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #162518
This PR updates the logic that detects whether Kibana has booted correctly during interactive setup.
The issue described in #162518 was a false positive and only effected Kibana when run in development mode.
We already have end-to-end tests which go through the entire enrollment flow and ensure that Kibana correctly redirects to the login page once interactive setup completes:
https://github.com/elastic/kibana/blob/main/test/interactive_setup_functional/tests/enrollment_token.ts#L78-L81
These tests passed with both the previous and the updated logic. However, the end-to-end tests do not check development mode which is why the build never failed and we started seeing this issue.