[security_solution] Improve Cypress burn logic #165130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💔 Build FailedFailed CI StepsMetrics [docs]Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
patrykkopycinski
added
the
release_note:skip
jbudz
approved these changes
Aug 30, 2023
yctercero
reviewed
Aug 30, 2023
| acc.push(existing); | ||
| } | ||
| return acc; | ||
| }, [] as string[]); | ||
|
|
||
| // to avoid running too many tests, we limit the number of files to 3 | ||
| // we may extend this in the future | ||
| files = files.slice(0, 3); |
There was a problem hiding this comment.
Will it always pick up the same 3 on a grep if there are more than 3 changed files?
There was a problem hiding this comment.
correct, until we reach the point where all our tests will be burn-ready I have limited it to just 3 files to avoid tests timeout
yctercero
approved these changes
Aug 30, 2023
kibanamachine
added
v8.11.0
backport:skip
eokoneyo
pushed a commit
to eokoneyo/kibana
that referenced
this pull request
Aug 31, 2023
## Summary Add `burn` scripts to `package.json` to simplify the process of testing spec files locally
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add
burnscripts topackage.jsonto simplify the process of testing spec files locally