Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Onboard Index Threshold Rule Type to use FAAD #164987

Merged
merged 8 commits into from
Sep 6, 2023

Conversation

ersin-erdal
Copy link
Contributor

@ersin-erdal ersin-erdal commented Aug 28, 2023

Resolves: #164222

This PR replaces AlertFactory in ES Query rule type with AlertsClient so the alerts are persistent in an alert-as-data index.

@ersin-erdal ersin-erdal self-assigned this Aug 28, 2023
@ersin-erdal ersin-erdal added release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.11.0 labels Aug 28, 2023
@ersin-erdal ersin-erdal marked this pull request as ready for review August 29, 2023 17:17
@ersin-erdal ersin-erdal requested a review from a team as a code owner August 29, 2023 17:17
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@ersin-erdal
Copy link
Contributor Author

@elasticmachine merge upstream

Copy link
Contributor

@ymao1 ymao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Able to see AAD docs for index threshold rule type! Left a few nits

@kibana-ci
Copy link
Collaborator

kibana-ci commented Sep 6, 2023

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #62 / Actions and Triggers app logs list "after all" hook for "should not show the logs space switch when multiple spaces exist but only one is accessible"
  • [job] [logs] FTR Configs #62 / Actions and Triggers app logs list should show the logs space switch when multiple spaces are accessible
  • [job] [logs] Serverless Security Cypress Tests #9 / Add, edit and delete exception Add, Edit and delete Exception item "before each" hook for "should create exception item from Shared Exception List page and linked to a Rule" "before each" hook for "should create exception item from Shared Exception List page and linked to a Rule"
  • [job] [logs] Serverless Security Investigations Cypress Tests #5 / Basic discover search and filter operations "before each" hook for "should change data when dataView is changed" "before each" hook for "should change data when dataView is changed"
  • [job] [logs] Serverless Security Investigations Cypress Tests #5 / Basic discover search and filter operations should change data when dataView is changed should change data when dataView is changed
  • [job] [logs] Serverless Security Cypress Tests #5 / Prebuilt rules Alerts rules, prebuilt rules "before each" hook for "Loads prebuilt rules" "before each" hook for "Loads prebuilt rules"
  • [job] [logs] Serverless Observability Tests / serverless common UI Data View Management "before all" hook for "Scripted fields tab is missing"
  • [job] [logs] Serverless Observability Examples Tests / serverless examples UI Unified Field List Examples Field stats field distribution "before all" hook for "should return an auto histogram for numbers and top values"
  • [job] [logs] Serverless Security Investigations Cypress Tests #6 / Toggle full screen "before each" hook for "Should hide timeline header and tab list area" "before each" hook for "Should hide timeline header and tab list area"

Metrics [docs]

Unknown metric groups

References to deprecated APIs

id before after diff
stackAlerts 63 62 -1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @ersin-erdal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.11.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Onboard Index Threshold Rule Type to use FAAD
5 participants