[File service] Fix integration tests #164958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebelga
added
test
Team:SharedUX
|
Pinging @elastic/appex-sharedux (Team:SharedUX) |
sebelga
added
the
release_note:skip
rshen91
approved these changes
Aug 29, 2023
rshen91
reviewed
Aug 29, 2023
| }) => { | ||
| if (refreshIndex) { | ||
| try { | ||
| // Make sure to refresh the index before deleting the file to avoid an conflict error thrown by |
💛 Build succeeded, but was flaky
Failed CI StepsTest FailuresMetrics [docs]
History
To update your PR or re-run it, just comment with: cc @sebelga |
kibanamachine
added
v8.11.0
backport:skip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR I fixed a flaky integration test. As within the test we upload and delete the file in a short timeframe the index was not refreshed and throw a conflict error (no documents found). I ran CI multiple times to be sure that the flakiness is fixed.
Fixes #144505
Fixes #144506