[Cloud Security] [Alerts] Fix alerts telemetry collector #164757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
opauloh
added
bug
|
Pinging @elastic/kibana-cloud-security-posture (Team:Cloud Security) |
maxcold
approved these changes
Aug 25, 2023
x-pack/plugins/cloud_security_posture/server/lib/telemetry/collectors/alert_stats_collector.ts
Show resolved
Hide resolved
|
@elasticmachine merge upstream |
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Aug 26, 2023
) (cherry picked from commit d18ef2f)
kibanamachine
added a commit
that referenced
this pull request
Aug 26, 2023
) (#164913) # Backport This will backport the following commits from `main` to `8.10`: - [[Cloud Security] [Alerts] Fix alerts telemetry collector (#164757)](#164757) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Paulo Henrique","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-08-26T04:25:52Z","message":"[Cloud Security] [Alerts] Fix alerts telemetry collector (#164757)","sha":"d18ef2f9797787b481345694b512dd56f40c0b48","branchLabelMapping":{"^v8.11.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:skip","Team:Cloud Security","backport:prev-minor","v8.10.0","v8.11.0"],"number":164757,"url":"https://github.com/elastic/kibana/pull/164757","mergeCommit":{"message":"[Cloud Security] [Alerts] Fix alerts telemetry collector (#164757)","sha":"d18ef2f9797787b481345694b512dd56f40c0b48"}},"sourceBranch":"main","suggestedTargetBranches":["8.10"],"targetPullRequestStates":[{"branch":"8.10","label":"v8.10.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.11.0","labelRegex":"^v8.11.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/164757","number":164757,"mergeCommit":{"message":"[Cloud Security] [Alerts] Fix alerts telemetry collector (#164757)","sha":"d18ef2f9797787b481345694b512dd56f40c0b48"}}]}] BACKPORT--> Co-authored-by: Paulo Henrique <[email protected]>
6 tasks
This was referenced Oct 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
It potentially closes https://github.com/elastic/security-team/issues/7411
Fixing Telemetry collector for detection rules created within the Cloud Security Posture Findings page. Also, it changes to only send posture-type data when it contains alert data.
Important to note that for 8.10 we are only collecting Rule telemetry for Rules that generated Alerts