[Security Solution] Fix flakiness in: prebuilt_rules_management.cy.ts - Deletes and recovers more than one rule
#164694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpdjere
added
test
release_note:skip
|
Pinging @elastic/security-detections-response (Team:Detections and Resp) |
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: cc @jpdjere |
jpdjere
added a commit
that referenced
this pull request
Aug 28, 2023
….cy.ts - Deletes and recovers more than one rule (#164824) **NOTE: This is a manual backport of #164694 Relates to: #161507 ## Summary - Solves flakiness in following test: - Filename: `x-pack/plugins/security_solution/cypress/e2e/detection_rules/prebuilt_rules_management.cy.ts` - Test name: **Prebuilt rules Actions with prebuilt rules Rules table Deletes and recovers more than one rule** - Test was failing because of already observed issue of `autoRefresh` taking place while the rule selection is happening, causing Cypress to lose focus and preventing the checkbox from being checked. This PR disables autorefresh from the table to prevent that from happening. ## Flaky test runner 350 iters: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2976 🟢
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Aug 28, 2023
…s` - Deletes and recovers more than one rule (elastic#164694) Relates to: elastic#161507 ## Summary - Solves flakiness in following test: - Filename: `x-pack/test/security_solution_cypress/cypress/e2e/detection_response/prebuilt_rules/prebuilt_rules_management.cy.ts` - Test name: **Prebuilt rules Actions with prebuilt rules Rules table Deletes and recovers more than one rule** - Test was failing because of already observed issue of `autoRefresh` taking place while the rule selection is happening, causing Cypress to lose focus and preventing the checkbox from being checked. This PR disables autorefresh from the table to prevent that from happening. ## Flaky test runner 350 iters: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2976 🟢 (cherry picked from commit e22f9b8)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Aug 28, 2023
…nt.cy.ts` - Deletes and recovers more than one rule (#164694) (#164961) # Backport This will backport the following commits from `main` to `8.10`: - [[Security Solution] Fix flakiness in: `prebuilt_rules_management.cy.ts` - Deletes and recovers more than one rule (#164694)](#164694) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Juan Pablo Djeredjian","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-08-28T11:02:22Z","message":"[Security Solution] Fix flakiness in: `prebuilt_rules_management.cy.ts` - Deletes and recovers more than one rule (#164694)\n\nRelates to: https://github.com/elastic/kibana/issues/161507\r\n\r\n## Summary\r\n\r\n- Solves flakiness in following test:\r\n- Filename:\r\n`x-pack/test/security_solution_cypress/cypress/e2e/detection_response/prebuilt_rules/prebuilt_rules_management.cy.ts`\r\n- Test name: **Prebuilt rules Actions with prebuilt rules Rules table\r\nDeletes and recovers more than one rule**\r\n\r\n- Test was failing because of already observed issue of `autoRefresh`\r\ntaking place while the rule selection is happening, causing Cypress to\r\nlose focus and preventing the checkbox from being checked. This PR\r\ndisables autorefresh from the table to prevent that from happening.\r\n\r\n## Flaky test runner\r\n\r\n350 iters:\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2976\r\n🟢","sha":"e22f9b860e6d62ddcaacae6a1b2f57178afa8e54","branchLabelMapping":{"^v8.11.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["test","release_note:skip","Team:Detections and Resp","Team: SecuritySolution","Feature:Rule Management","Team:Detection Rule Management","v8.10.0","v8.11.0"],"number":164694,"url":"https://github.com/elastic/kibana/pull/164694","mergeCommit":{"message":"[Security Solution] Fix flakiness in: `prebuilt_rules_management.cy.ts` - Deletes and recovers more than one rule (#164694)\n\nRelates to: https://github.com/elastic/kibana/issues/161507\r\n\r\n## Summary\r\n\r\n- Solves flakiness in following test:\r\n- Filename:\r\n`x-pack/test/security_solution_cypress/cypress/e2e/detection_response/prebuilt_rules/prebuilt_rules_management.cy.ts`\r\n- Test name: **Prebuilt rules Actions with prebuilt rules Rules table\r\nDeletes and recovers more than one rule**\r\n\r\n- Test was failing because of already observed issue of `autoRefresh`\r\ntaking place while the rule selection is happening, causing Cypress to\r\nlose focus and preventing the checkbox from being checked. This PR\r\ndisables autorefresh from the table to prevent that from happening.\r\n\r\n## Flaky test runner\r\n\r\n350 iters:\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2976\r\n🟢","sha":"e22f9b860e6d62ddcaacae6a1b2f57178afa8e54"}},"sourceBranch":"main","suggestedTargetBranches":["8.10"],"targetPullRequestStates":[{"branch":"8.10","label":"v8.10.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.11.0","labelRegex":"^v8.11.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/164694","number":164694,"mergeCommit":{"message":"[Security Solution] Fix flakiness in: `prebuilt_rules_management.cy.ts` - Deletes and recovers more than one rule (#164694)\n\nRelates to: https://github.com/elastic/kibana/issues/161507\r\n\r\n## Summary\r\n\r\n- Solves flakiness in following test:\r\n- Filename:\r\n`x-pack/test/security_solution_cypress/cypress/e2e/detection_response/prebuilt_rules/prebuilt_rules_management.cy.ts`\r\n- Test name: **Prebuilt rules Actions with prebuilt rules Rules table\r\nDeletes and recovers more than one rule**\r\n\r\n- Test was failing because of already observed issue of `autoRefresh`\r\ntaking place while the rule selection is happening, causing Cypress to\r\nlose focus and preventing the checkbox from being checked. This PR\r\ndisables autorefresh from the table to prevent that from happening.\r\n\r\n## Flaky test runner\r\n\r\n350 iters:\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2976\r\n🟢","sha":"e22f9b860e6d62ddcaacae6a1b2f57178afa8e54"}}]}] BACKPORT--> Co-authored-by: Juan Pablo Djeredjian <[email protected]>
This was referenced Oct 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to: #161507
Summary
Solves flakiness in following test:
x-pack/test/security_solution_cypress/cypress/e2e/detection_response/prebuilt_rules/prebuilt_rules_management.cy.tsTest was failing because of already observed issue of
autoRefreshtaking place while the rule selection is happening, causing Cypress to lose focus and preventing the checkbox from being checked. This PR disables autorefresh from the table to prevent that from happening.Flaky test runner
350 iters: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2976 🟢