[Fleet] Change 'Out-of-date' to 'Outdated policy' in agent list table #164673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hop-dev
added
release_note:enhancement
Team:Fleet
|
Pinging @elastic/fleet (Team:Fleet) |
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
hop-dev
changed the title
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: cc @hop-dev |
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Aug 24, 2023
…elastic#164673) ## Summary Closes elastic#164575. Bonus: also fix the bug where the warning goes under the policy revision I thought that looked a bit weird. Double bonus: Updated the create agent test script to be able to create outdated agents + to use nicer policy names so the table doesnt get messy Before: <img width="1237" alt="Screenshot 2023-08-24 at 10 10 58" src="https://github.com/elastic/kibana/assets/3315046/86a88ad6-a2c7-4f17-82bb-fe026d05d937"> After: <img width="1244" alt="Screenshot 2023-08-24 at 10 09 53" src="https://github.com/elastic/kibana/assets/3315046/1cf76dd3-2e6a-4aa9-a004-109797f54c52"> (cherry picked from commit 1610e32)
jloleysens
added a commit
that referenced
this pull request
Aug 24, 2023
* main: (3152 commits) [Security Solution][Detection Engine] fixes 410 error on index legacy template call (#164682) [SavedObjects] Create serverless roots for jest integration tests (#164157) Create upselling package and implement EntityAnalytics serverless upselling (#164136) [Fleet] Change 'Out-of-date' to 'Outdated policy' in agent list table (#164673) [IndexManagement] Use internal base path for API (#164665) [Profiling] removing ~ symbol (#164595) [Telemetry] Fetch snapshot: allow specifying the version via querystring (#164670) [Cases] Show warning when all cases table reaches 10k cases message (#164323) [ML] Removing token list from text expansion model testing (#164560) [Fleet] Add secrets package API integration test (#164583) [Fleet] Fix security solution tag id (#164582) [Security Solution] Modal says "duplicating 0 rules" when you duplicate an individual rule (#163908) [api-docs] 2023-08-24 Daily api_docs build (#164658) [APM] Cleanup alerting api tests (#164438) Upgrade EUI to 87.2.0 (#164385) [ML] Fix query bar autocompletion for ML and AIOps embeddables (#164485) [Fleet] Fix flaky unit test for the details page (#164641) [Security Solution] update codeowner for serverless security subdir (#164640) [Security Solution] Fixes Assistant Connector and Actions RBAC Flow (#164382) [Discover] Removing large string truncation from doc viewer (#164236) ...
kibanamachine
added a commit
that referenced
this pull request
Aug 24, 2023
…t table (#164673) (#164691) # Backport This will backport the following commits from `main` to `8.10`: - [[Fleet] Change 'Out-of-date' to 'Outdated policy' in agent list table (#164673)](#164673) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Mark Hopkin","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-08-24T11:05:44Z","message":"[Fleet] Change 'Out-of-date' to 'Outdated policy' in agent list table (#164673)\n\n## Summary\r\n\r\nCloses #164575.\r\n\r\nBonus: also fix the bug where the warning goes under the policy revision\r\nI thought that looked a bit weird.\r\n\r\nDouble bonus: Updated the create agent test script to be able to create\r\noutdated agents + to use nicer policy names so the table doesnt get\r\nmessy\r\n\r\nBefore:\r\n\r\n<img width=\"1237\" alt=\"Screenshot 2023-08-24 at 10 10 58\"\r\nsrc=\"https://github.com/elastic/kibana/assets/3315046/86a88ad6-a2c7-4f17-82bb-fe026d05d937\">\r\n\r\n\r\nAfter:\r\n\r\n<img width=\"1244\" alt=\"Screenshot 2023-08-24 at 10 09 53\"\r\nsrc=\"https://github.com/elastic/kibana/assets/3315046/1cf76dd3-2e6a-4aa9-a004-109797f54c52\">","sha":"1610e32972f51b17a34e2a1f3d8b465bc18fd5c3","branchLabelMapping":{"^v8.11.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:enhancement","Team:Fleet","backport:prev-minor","v8.11.0"],"number":164673,"url":"https://github.com/elastic/kibana/pull/164673","mergeCommit":{"message":"[Fleet] Change 'Out-of-date' to 'Outdated policy' in agent list table (#164673)\n\n## Summary\r\n\r\nCloses #164575.\r\n\r\nBonus: also fix the bug where the warning goes under the policy revision\r\nI thought that looked a bit weird.\r\n\r\nDouble bonus: Updated the create agent test script to be able to create\r\noutdated agents + to use nicer policy names so the table doesnt get\r\nmessy\r\n\r\nBefore:\r\n\r\n<img width=\"1237\" alt=\"Screenshot 2023-08-24 at 10 10 58\"\r\nsrc=\"https://github.com/elastic/kibana/assets/3315046/86a88ad6-a2c7-4f17-82bb-fe026d05d937\">\r\n\r\n\r\nAfter:\r\n\r\n<img width=\"1244\" alt=\"Screenshot 2023-08-24 at 10 09 53\"\r\nsrc=\"https://github.com/elastic/kibana/assets/3315046/1cf76dd3-2e6a-4aa9-a004-109797f54c52\">","sha":"1610e32972f51b17a34e2a1f3d8b465bc18fd5c3"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.11.0","labelRegex":"^v8.11.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/164673","number":164673,"mergeCommit":{"message":"[Fleet] Change 'Out-of-date' to 'Outdated policy' in agent list table (#164673)\n\n## Summary\r\n\r\nCloses #164575.\r\n\r\nBonus: also fix the bug where the warning goes under the policy revision\r\nI thought that looked a bit weird.\r\n\r\nDouble bonus: Updated the create agent test script to be able to create\r\noutdated agents + to use nicer policy names so the table doesnt get\r\nmessy\r\n\r\nBefore:\r\n\r\n<img width=\"1237\" alt=\"Screenshot 2023-08-24 at 10 10 58\"\r\nsrc=\"https://github.com/elastic/kibana/assets/3315046/86a88ad6-a2c7-4f17-82bb-fe026d05d937\">\r\n\r\n\r\nAfter:\r\n\r\n<img width=\"1244\" alt=\"Screenshot 2023-08-24 at 10 09 53\"\r\nsrc=\"https://github.com/elastic/kibana/assets/3315046/1cf76dd3-2e6a-4aa9-a004-109797f54c52\">","sha":"1610e32972f51b17a34e2a1f3d8b465bc18fd5c3"}}]}] BACKPORT--> Co-authored-by: Mark Hopkin <[email protected]>
This was referenced Oct 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #164575.
Bonus: also fix the bug where the warning goes under the policy revision I thought that looked a bit weird.
Double bonus: Updated the create agent test script to be able to create outdated agents + to use nicer policy names so the table doesnt get messy
Before:
After: