remove unneeded usages of isErrorResponse

[nreese]

data.search uses poll_search to fetch data. poll_search checks for isErrorResponse and throws whenisErrorResponse is true. Note searchSource.search uses data.search to perform searches.

   return from(search()).pipe(
      expand(() => {
        const elapsedTime = Date.now() - startTime;
        return timer(getPollInterval(elapsedTime)).pipe(switchMap(search));
      }),
      tap((response) => {
        if (isErrorResponse(response)) {
          throw response ? new Error('Received partial response') : new AbortError();
        }
      }),
      takeWhile<Response>(isPartialResponse, true),
      takeUntil<Response>(aborted$)
    );

Subscribers to data.search and searchSource.search do not need to check for isErrorResponse in next. poll_search has already thrown then the response is isErrorResponse so these checks are dead code blocks that are never executed.

This PR removes these dead code blocks. Breaking this change out of #164506 so that it can be reviewed in isolated.

[nreese]

@elasticmachine merge upstream

[nreese]

@elasticmachine merge upstream

[elasticmachine]

Pinging @elastic/kibana-presentation (Team:Presentation)

[rylnd]

I'm not very familiar with the search_strategy code so I'm going to defer on approving this, but it does look like that translation can now be removed as well 👍

[nreese]

I'm not very familiar with the search_strategy code so I'm going to defer on approving this

Are there any edge cases that have broken search in security solution before? You could try testing those

[rylnd]

Are there any edge cases that have broken search in security solution before? You could try testing those

I defer to my previous statement 😅

Apologies, I came here from the general ping to security-solution (which is a weird consequence of the CODEOWNERS structure ?); the Threat Hunting teams listed in reviewers are going to have the best context here.

[darnautov]

ML changes LGTM

[dej611]

Code review only 👍

[logeekal]

Are there any edge cases that have broken search in security solution before? You could try testing those

Overall changes in security solutions look good to me but I deferred the approval before I discuss with my team regarding any edge that might be affected. Although, mostly cypress tests should already cover it.

[lukasolson]

LGTM, tested a few different error types and functionality hasn't changed.

[machadoum]

threat-hunting-explore changes LGTM!

[nreese]

@elasticmachine merge upstream

[kibana-ci]

💛 Build succeeded, but was flaky

• Buildkite Build
• Commit: 727ad10

Failed CI Steps

• Defend Workflows Endpoint Cypress Tests #1
• Defend Workflows Endpoint Cypress Tests #4

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
securitySolution	4473	4472	-1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
aiops	593.7KB	593.6KB	-102.0B
securitySolution	16.0MB	16.0MB	-4.9KB
threatIntelligence	56.6KB	56.5KB	-60.0B
triggersActionsUi	1.5MB	1.5MB	-175.0B
total			-5.2KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
data	404.6KB	404.5KB	-48.0B

History

• 💛 Build #153371 was flaky 265f833
• 💔 Build #153364 failed 251df10
• 💔 Build #153343 failed 91b41ca
• 💔 Build #153338 failed 98402ac
• 💔 Build #153328 failed 709e82e840e1f96330f5ae12febbff9119c9370d

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

[PhilippeOberti]

LGTM for the Protections Experience team! :)

[pmuellr]

LGTM