Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ops] Trigger quality gate pipelines #164580

Closed
wants to merge 3 commits into from

Conversation

delanni
Copy link
Contributor

@delanni delanni commented Aug 23, 2023

Summary

Closes: https://github.com/elastic/kibana-operations/issues/10

  • chore(quality-gates): trigger downstream test pipelines from quality-gates

Issues along the way:

  • Should we run the pipeline jobs FROM the pipeline.ymls, or should we trigger them?
    • Solution: triggering seems better. It can run on a different agent, so no issue with the kibana-flavored agents
  • We would like to run a pipeline job IN kibana’s codebase BUT with the ci-systems pipelines. This is a problem because kibana has some scripts that assume, you’ll do something with Kibana. Now, these pipelines will just trigger other downstream jobs.
    • Solution: somehow skip the hooks if it’s not a kibana-flavored pipeline. For now, a manually set flag SKIP_KIBANA_HOOKS=1
  • The pipeline can only be tested with elastic/kibana branches.
    • Solution: don’t use my mirror for this PR, at least while working on it
  • The catalog-info.yaml points to a missing file ↔ the head quality-gate pipeline file is not in the right place
  • Missing ENVIRONMENT. Who’s going to set that variable? It’s not set at any points, the head pipeline assumes it’s present, but probably it’s not needed.
    • Solution: for now, we can add this manually
    • Question: Who/how/when will trigger this job?
  • Manual testing can’t trigger certain jobs

@delanni delanni force-pushed the run-kibana-quality-gate-suites branch from 3e0e2f6 to 23d4b25 Compare August 29, 2023 07:29
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

  • 💚 Build #152763 succeeded 3e0e2f6b3413de05355b7b650b87e5d7fc9a1a1b

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@delanni
Copy link
Contributor Author

delanni commented Aug 31, 2023

Closed in favor of: #165346

@delanni delanni closed this Aug 31, 2023
@delanni delanni deleted the run-kibana-quality-gate-suites branch May 2, 2024 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants