[8.9] [Security Selection][Detection engine] fixes rule preview performance issues (#164207) #164487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… issues (elastic#164207) ## Summary On every single keyboard type on query input, the whole preview part was re-rendering. If there are too many alerts, it could take ~150ms-200ms, for its re-render. Ultimately, making form almost unusable So, in this PR I'm adding memoization for 2 Preview components, to resolve this issue ### Before <img width="2529" alt="Screenshot 2023-08-17 at 17 13 07" src="https://github.com/elastic/kibana/assets/92328789/c0b137e6-828b-4068-b061-85a5b5ca99f1"> ### After <img width="2523" alt="Screenshot 2023-08-17 at 17 07 56" src="https://github.com/elastic/kibana/assets/92328789/06a0983c-d8e0-40c1-9b48-fd4bc106e922"> --------- Co-authored-by: kibanamachine <[email protected]> (cherry picked from commit cd8a94b)
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
💚 Build Succeeded
Metrics [docs]Async chunks
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
To update your PR or re-run it, just comment with: cc @vitaliidm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.9:Questions ?
Please refer to the Backport tool documentation