Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ingest Pipelines] Fix accessibility tests #164341

Merged
merged 1 commit into from
Aug 23, 2023
Merged

[Ingest Pipelines] Fix accessibility tests #164341

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions x-pack/test/accessibility/apps/ingest_node_pipelines.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,7 @@ export default function ({ getService, getPageObjects }: any) {
const log = getService('log');
const a11y = getService('a11y'); /* this is the wrapping service around axe */

// FAILING ES PROMOTION: https://github.com/elastic/kibana/issues/157512
describe.skip('Ingest Pipelines Accessibility', async () => {
describe('Ingest Pipelines Accessibility', async () => {
before(async () => {
await putSamplePipeline(esClient);
await common.navigateToApp('ingestPipelines');
Expand All @@ -29,7 +28,7 @@ export default function ({ getService, getPageObjects }: any) {
await a11y.testAppSnapshot();
});

it('List View', async () => {
it('Details View', async () => {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixing test description

await testSubjects.click('pipelineDetailsLink');
await retry.waitFor('testPipeline detail panel to be visible', async () => {
if (!testSubjects.isDisplayed('pipelineDetails')) {
Expand All @@ -50,8 +49,7 @@ export default function ({ getService, getPageObjects }: any) {
});

it('Create Pipeline Wizard', async () => {
await testSubjects.click('emptyStateCreatePipelineDropdown');
await testSubjects.click('emptyStateCreatePipelineButton');
await common.navigateToUrl('ingestPipelines', 'create', { shouldUseHashForSubUrl: false });
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The previous code was failing bc it was expecting the create button from the empty state view. Rather than depending on pipelines to exist/not exist, we navigate directly to the create page.

await retry.waitFor('Create pipeline page one to be visible', async () => {
return testSubjects.isDisplayed('pageTitle') ? true : false;
});
Expand Down