[Security Solution][Endpoint] Fixes kibana crash when going back to policy details page #164329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dasansol92
added
release_note:skip
|
Pinging @elastic/security-defend-workflows (Team:Defend Workflows) |
pzl
approved these changes
Aug 21, 2023
kevinlog
approved these changes
Aug 21, 2023
|
@elasticmachine merge upstream |
…policy_details-164295
|
@elasticmachine merge upstream |
…policy_details-164295
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Aug 23, 2023
…olicy details page (elastic#164329) Fixes: elastic#164295 Fixes: elastic#164190 ## Summary There was a Kibana crash when using back link buttons to go back to the policy details page from Trusted Apps / Event Filters / Host Isolation exceptions / Blocklists page. Route state can be null depending on the previous action so it has to be conditional. The error occurs when it tries to access the `backLink` prop on `routeState` when it's not defined. Co-authored-by: Kibana Machine <[email protected]> (cherry picked from commit fb79e3e)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Aug 23, 2023
…olicy details page (elastic#164329) Fixes: elastic#164295 Fixes: elastic#164190 ## Summary There was a Kibana crash when using back link buttons to go back to the policy details page from Trusted Apps / Event Filters / Host Isolation exceptions / Blocklists page. Route state can be null depending on the previous action so it has to be conditional. The error occurs when it tries to access the `backLink` prop on `routeState` when it's not defined. Co-authored-by: Kibana Machine <[email protected]> (cherry picked from commit fb79e3e)
kibanamachine
added a commit
that referenced
this pull request
Aug 23, 2023
…k to policy details page (#164329) (#164556) # Backport This will backport the following commits from `main` to `8.9`: - [[Security Solution][Endpoint] Fixes kibana crash when going back to policy details page (#164329)](#164329) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"David Sánchez","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-08-23T10:44:11Z","message":"[Security Solution][Endpoint] Fixes kibana crash when going back to policy details page (#164329)\n\nFixes: https://github.com/elastic/kibana/issues/164295\r\nFixes: https://github.com/elastic/kibana/issues/164190\r\n\r\n## Summary\r\nThere was a Kibana crash when using back link buttons to go back to the\r\npolicy details page from Trusted Apps / Event Filters / Host Isolation\r\nexceptions / Blocklists page. Route state can be null depending on the\r\nprevious action so it has to be conditional.\r\n\r\nThe error occurs when it tries to access the `backLink` prop on\r\n`routeState` when it's not defined.\r\n\r\nCo-authored-by: Kibana Machine <[email protected]>","sha":"fb79e3e86430418c8a10d1cb9041c5e4f901a436","branchLabelMapping":{"^v8.11.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Defend Workflows","v8.10.0","v8.11.0","v8.9.2"],"number":164329,"url":"https://github.com/elastic/kibana/pull/164329","mergeCommit":{"message":"[Security Solution][Endpoint] Fixes kibana crash when going back to policy details page (#164329)\n\nFixes: https://github.com/elastic/kibana/issues/164295\r\nFixes: https://github.com/elastic/kibana/issues/164190\r\n\r\n## Summary\r\nThere was a Kibana crash when using back link buttons to go back to the\r\npolicy details page from Trusted Apps / Event Filters / Host Isolation\r\nexceptions / Blocklists page. Route state can be null depending on the\r\nprevious action so it has to be conditional.\r\n\r\nThe error occurs when it tries to access the `backLink` prop on\r\n`routeState` when it's not defined.\r\n\r\nCo-authored-by: Kibana Machine <[email protected]>","sha":"fb79e3e86430418c8a10d1cb9041c5e4f901a436"}},"sourceBranch":"main","suggestedTargetBranches":["8.10","8.9"],"targetPullRequestStates":[{"branch":"8.10","label":"v8.10.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.11.0","labelRegex":"^v8.11.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/164329","number":164329,"mergeCommit":{"message":"[Security Solution][Endpoint] Fixes kibana crash when going back to policy details page (#164329)\n\nFixes: https://github.com/elastic/kibana/issues/164295\r\nFixes: https://github.com/elastic/kibana/issues/164190\r\n\r\n## Summary\r\nThere was a Kibana crash when using back link buttons to go back to the\r\npolicy details page from Trusted Apps / Event Filters / Host Isolation\r\nexceptions / Blocklists page. Route state can be null depending on the\r\nprevious action so it has to be conditional.\r\n\r\nThe error occurs when it tries to access the `backLink` prop on\r\n`routeState` when it's not defined.\r\n\r\nCo-authored-by: Kibana Machine <[email protected]>","sha":"fb79e3e86430418c8a10d1cb9041c5e4f901a436"}},{"branch":"8.9","label":"v8.9.2","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: David Sánchez <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Aug 23, 2023
…ck to policy details page (#164329) (#164555) # Backport This will backport the following commits from `main` to `8.10`: - [[Security Solution][Endpoint] Fixes kibana crash when going back to policy details page (#164329)](#164329) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"David Sánchez","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-08-23T10:44:11Z","message":"[Security Solution][Endpoint] Fixes kibana crash when going back to policy details page (#164329)\n\nFixes: https://github.com/elastic/kibana/issues/164295\r\nFixes: https://github.com/elastic/kibana/issues/164190\r\n\r\n## Summary\r\nThere was a Kibana crash when using back link buttons to go back to the\r\npolicy details page from Trusted Apps / Event Filters / Host Isolation\r\nexceptions / Blocklists page. Route state can be null depending on the\r\nprevious action so it has to be conditional.\r\n\r\nThe error occurs when it tries to access the `backLink` prop on\r\n`routeState` when it's not defined.\r\n\r\nCo-authored-by: Kibana Machine <[email protected]>","sha":"fb79e3e86430418c8a10d1cb9041c5e4f901a436","branchLabelMapping":{"^v8.11.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Defend Workflows","v8.10.0","v8.11.0","v8.9.2"],"number":164329,"url":"https://github.com/elastic/kibana/pull/164329","mergeCommit":{"message":"[Security Solution][Endpoint] Fixes kibana crash when going back to policy details page (#164329)\n\nFixes: https://github.com/elastic/kibana/issues/164295\r\nFixes: https://github.com/elastic/kibana/issues/164190\r\n\r\n## Summary\r\nThere was a Kibana crash when using back link buttons to go back to the\r\npolicy details page from Trusted Apps / Event Filters / Host Isolation\r\nexceptions / Blocklists page. Route state can be null depending on the\r\nprevious action so it has to be conditional.\r\n\r\nThe error occurs when it tries to access the `backLink` prop on\r\n`routeState` when it's not defined.\r\n\r\nCo-authored-by: Kibana Machine <[email protected]>","sha":"fb79e3e86430418c8a10d1cb9041c5e4f901a436"}},"sourceBranch":"main","suggestedTargetBranches":["8.10","8.9"],"targetPullRequestStates":[{"branch":"8.10","label":"v8.10.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.11.0","labelRegex":"^v8.11.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/164329","number":164329,"mergeCommit":{"message":"[Security Solution][Endpoint] Fixes kibana crash when going back to policy details page (#164329)\n\nFixes: https://github.com/elastic/kibana/issues/164295\r\nFixes: https://github.com/elastic/kibana/issues/164190\r\n\r\n## Summary\r\nThere was a Kibana crash when using back link buttons to go back to the\r\npolicy details page from Trusted Apps / Event Filters / Host Isolation\r\nexceptions / Blocklists page. Route state can be null depending on the\r\nprevious action so it has to be conditional.\r\n\r\nThe error occurs when it tries to access the `backLink` prop on\r\n`routeState` when it's not defined.\r\n\r\nCo-authored-by: Kibana Machine <[email protected]>","sha":"fb79e3e86430418c8a10d1cb9041c5e4f901a436"}},{"branch":"8.9","label":"v8.9.2","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: David Sánchez <[email protected]>
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Aug 23, 2023
* main: (150 commits) Fixes unnecessary autocompletes on HTTP methods (elastic#163233) [Defend Workflows] Convert filterQuery to kql (elastic#161806) [Fleet] copy `inactivity_timeout` when duplicating agent policy (elastic#164544) Fix 7.17 forward compatibility with 8.2+ (elastic#164274) [ML] Fixes dark mode in flyouts and modals (elastic#164399) [Defend Workflows]Changes to policy settings are not persistent until a refresh (elastic#164403) [Security Solution][Endpoint] Fixes kibana crash when going back to policy details page (elastic#164329) Prepare the Security domain HTTP APIs for Serverless (elastic#162087) skip failing test suite (elastic#160986) [Security Solution] Fix flaky Event Filters test (elastic#164473) [EDR workflows] Osquery serverless tests (elastic#163795) [Fleet] Only show agent dashboard links if there is more than one non-server agent and if the dashboards exist (elastic#164469) [Chrome UI] Fix background color in serverless (elastic#164419) [DOCS] Saved objects - resolve import errors API (elastic#162825) Remove 'Create Rule' button from Rule Group page (elastic#164167) [Security Solution] expandable flyout - fix infinite loop in correlations (elastic#163450) [Remote Clusters] Update copy about port help text (elastic#164442) [api-docs] 2023-08-23 Daily api_docs build (elastic#164524) [data views] Disable scripted fields in serverless environment (elastic#163228) [Reporting] Fix - show diagnostic only when image reporting is enabled (elastic#164336) ...
This was referenced Oct 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #164295
Fixes: #164190
Summary
There was a Kibana crash when using back link buttons to go back to the policy details page from Trusted Apps / Event Filters / Host Isolation exceptions / Blocklists page. Route state can be null depending on the previous action so it has to be conditional.
The error occurs when it tries to access the
backLinkprop onrouteStatewhen it's not defined.