Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cloud Security] removed beta label from tty setting #164122

Merged
merged 6 commits into from
Aug 17, 2023

Conversation

mitodrummer
Copy link
Contributor

@mitodrummer mitodrummer commented Aug 16, 2023

Summary

Removes a beta label from the "terminal output" feature in the linux settings for the endpoint integration. The beta tag was previously removed from the TTY player itself, but this spot was missed.

Also, this PR changes codeowners of session_view, kubernetes_security and cloud_defend plugins to the kibana-cloud-security-posture team

@mitodrummer mitodrummer requested a review from a team as a code owner August 16, 2023 23:23
@mitodrummer mitodrummer requested review from pzl and ashokaditya August 16, 2023 23:23
@mitodrummer mitodrummer added the Team:Cloud Security Cloud Security team related label Aug 16, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-cloud-security-posture (Team:Cloud Security)

@mitodrummer mitodrummer added release_note:skip Skip the PR/issue when compiling release notes backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) v8.10.0 labels Aug 16, 2023
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 15.7MB 15.7MB -16.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@mitodrummer mitodrummer merged commit 4ce5464 into elastic:main Aug 17, 2023
@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
8.10 Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 164122

Questions ?

Please refer to the Backport tool documentation

@mitodrummer
Copy link
Contributor Author

💚 All backports created successfully

Status Branch Result
8.10

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

mitodrummer added a commit to mitodrummer/kibana that referenced this pull request Aug 22, 2023
Removes a beta label from the "terminal output" feature in the linux
settings for the endpoint integration. The beta tag was previously
removed from the TTY player itself, but this spot was missed.

---------

Co-authored-by: kibanamachine <[email protected]>
(cherry picked from commit 4ce5464)
mitodrummer added a commit that referenced this pull request Aug 23, 2023
## Summary

This fixes some missed spots when I changed CODEOWNERS in this PR:
#164122

Forgot to update all the kibana.jsonc files, so CI overwrote my changes
in CODEOWNERS :)

---------

Co-authored-by: kibanamachine <[email protected]>
mitodrummer added a commit that referenced this pull request Aug 24, 2023
…#164521)

# Backport

This will backport the following commits from `main` to `8.10`:
- [[Cloud Security] removed beta label from tty setting
(#164122)](#164122)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Karl
Godard","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-08-17T17:15:32Z","message":"[Cloud
Security] removed beta label from tty setting (#164122)\n\n##
Summary\r\n\r\nRemoves a beta label from the \"terminal output\" feature
in the linux\r\nsettings for the endpoint integration. The beta tag was
previously\r\nremoved from the TTY player itself, but this spot was
missed.\r\n\r\nAlso, this PR changes codeowners of session_view,
kubernetes_security\r\nand cloud_defend plugins to the
**kibana-cloud-security-posture**
team\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine
<[email protected]>","sha":"4ce54648f8d4452ae2995392da07a32bf541ff20","branchLabelMapping":{"^v8.10.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Cloud
Security","backport:prev-minor","v8.10.0","v8.11.0"],"number":164122,"url":"https://github.com/elastic/kibana/pull/164122","mergeCommit":{"message":"[Cloud
Security] removed beta label from tty setting (#164122)\n\n##
Summary\r\n\r\nRemoves a beta label from the \"terminal output\" feature
in the linux\r\nsettings for the endpoint integration. The beta tag was
previously\r\nremoved from the TTY player itself, but this spot was
missed.\r\n\r\nAlso, this PR changes codeowners of session_view,
kubernetes_security\r\nand cloud_defend plugins to the
**kibana-cloud-security-posture**
team\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine
<[email protected]>","sha":"4ce54648f8d4452ae2995392da07a32bf541ff20"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.10.0","labelRegex":"^v8.10.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/164122","number":164122,"mergeCommit":{"message":"[Cloud
Security] removed beta label from tty setting (#164122)\n\n##
Summary\r\n\r\nRemoves a beta label from the \"terminal output\" feature
in the linux\r\nsettings for the endpoint integration. The beta tag was
previously\r\nremoved from the TTY player itself, but this spot was
missed.\r\n\r\nAlso, this PR changes codeowners of session_view,
kubernetes_security\r\nand cloud_defend plugins to the
**kibana-cloud-security-posture**
team\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine
<[email protected]>","sha":"4ce54648f8d4452ae2995392da07a32bf541ff20"}},{"branch":"8.11","label":"v8.11.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Kibana Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) release_note:skip Skip the PR/issue when compiling release notes Team:Cloud Security Cloud Security team related v8.10.0 v8.11.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants