Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Event annotations] add types to integration tests #164103

Merged
merged 2 commits into from
Aug 17, 2023

Conversation

drewdaemon
Copy link
Contributor

Summary

Just improving the integration tests so that if a type changes, we'll know to update them.

@drewdaemon drewdaemon added the Team:Visualizations Visualization editors, elastic-charts and infrastructure label Aug 16, 2023
@drewdaemon drewdaemon marked this pull request as ready for review August 16, 2023 17:08
@drewdaemon drewdaemon requested a review from a team as a code owner August 16, 2023 17:08
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-visualizations @elastic/kibana-visualizations-external (Team:Visualizations)

@drewdaemon drewdaemon added the release_note:skip Skip the PR/issue when compiling release notes label Aug 16, 2023
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #45 / dashboard app - group 1 dashboard embeddable data grid "before all" hook for "should expand the detail row when the toggle arrow is clicked"

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
eventAnnotation 191 195 +4

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
eventAnnotation 176.7KB 176.7KB -1.0B

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
eventAnnotation 2 5 +3

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
eventAnnotation 21.4KB 21.4KB +52.0B
Unknown metric groups

API count

id before after diff
eventAnnotation 191 195 +4

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@dej611 dej611 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review only 👍

@drewdaemon drewdaemon merged commit 276cf86 into elastic:main Aug 17, 2023
@kibanamachine kibanamachine added v8.11.0 backport:skip This commit does not require backporting labels Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.11.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants