[Lens] allow removing ad-hoc data view from event annotation group #163976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drewdaemon
force-pushed
the
163894/fix-annotation-save-bug
branch
from
353a10b to
85a4f74
Compare
|
@elasticmachine merge upstream |
drewdaemon
added
release_note:fix
Team:Visualizations
|
Pinging @elastic/kibana-visualizations @elastic/kibana-visualizations-external (Team:Visualizations) |
4 tasks
|
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
drewdaemon
added a commit
to drewdaemon/kibana
that referenced
this pull request
Aug 16, 2023
…lastic#163976) (cherry picked from commit 08a48f3) # Conflicts: # .github/CODEOWNERS
drewdaemon
added a commit
that referenced
this pull request
Aug 16, 2023
…oup (#163976) (#164101) # Backport This will backport the following commits from `main` to `8.9`: - [[Lens] allow removing ad-hoc data view from event annotation group (#163976)](#163976) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Drew Tate","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-08-16T15:24:15Z","message":"[Lens] allow removing ad-hoc data view from event annotation group (#163976)","sha":"08a48f3cf1a928d2e01dbe1e867326ae54afbb5a","branchLabelMapping":{"^v8.10.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:Visualizations","v8.9.0","v8.10.0"],"number":163976,"url":"https://github.com/elastic/kibana/pull/163976","mergeCommit":{"message":"[Lens] allow removing ad-hoc data view from event annotation group (#163976)","sha":"08a48f3cf1a928d2e01dbe1e867326ae54afbb5a"}},"sourceBranch":"main","suggestedTargetBranches":["8.9"],"targetPullRequestStates":[{"branch":"8.9","label":"v8.9.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.10.0","labelRegex":"^v8.10.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/163976","number":163976,"mergeCommit":{"message":"[Lens] allow removing ad-hoc data view from event annotation group (#163976)","sha":"08a48f3cf1a928d2e01dbe1e867326ae54afbb5a"}}]}] BACKPORT-->
|
This pr didn't make it into the build candidate for v8.9.1. Updating the labels. |
bryce-b
pushed a commit
that referenced
this pull request
Aug 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix #163894
undefinedwas being used instead ofnullto indicate no ad-hoc data view spec. This was problematic sinceundefinedproperties are evicted from the object during JSON serializationThe bug was introduced with #159692.
I have
Checklist