-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
QG Scaffold #163831
QG Scaffold #163831
Conversation
The main question is here did I get the ownership correct, is there a better group to name? From what I understand the main thing ownership enables is writing secrets to the repo's namespace in vault for buildkite.
I think the ownership in a "Component" is just a backstage component entity link to the team. The vault space is opened for github repos, so I believe we need to have Probably we can add the kibana-tests pipeline here already in this PR. Depending on the way the solutions team wants to define their quality gates: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm,
but the final approval should come from one of the teams
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general it looks good. I have a bunch of questions, mostly related to catalog-info.yaml
. But I'm sure it's just me still learning...
- label: ":pipeline::fleet::seedling: Trigger Fleet Kibana Tests for ${ENVIRONMENT}" | ||
command: echo "replace me with Fleet specific Kibana tests" | ||
agent: | ||
image: "docker.elastic.co/ci-agent-images/basic-buildkite-agent:1688566364" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @juliaElastic this and the pipeline below for staging is where we may hook in the smoke pipeline you're working on. Please leave any feedback here if you see any problems.
…a into register-kibana-backstage
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pipelines / casing check LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@watson, from our side this is ready to go. |
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
The main question is here did I get the github team names correct for fleet and security? Are there any other groups I am missing who will have quality gates they want to see execute on every kibana release?
Rel: https://github.com/elastic/ingest-dev/issues/2201
Rel: https://elasticco.atlassian.net/browse/QX-282