Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QG Scaffold #163831

Merged
merged 18 commits into from
Aug 22, 2023
Merged

QG Scaffold #163831

merged 18 commits into from
Aug 22, 2023

Conversation

imkarrer
Copy link
Contributor

@imkarrer imkarrer commented Aug 14, 2023

The main question is here did I get the github team names correct for fleet and security? Are there any other groups I am missing who will have quality gates they want to see execute on every kibana release?

  • The PR which registered the repo and controls who can write secrets to vault was merged here
  • Quality gate registration with argo deploy pipeline here. Should merge after this and pipelines are working.
  • this one merges last and tells terrazzo about the catalog-info.yaml file with our pipeline. Other pipelines should be migrated over but are not included here.

Rel: https://github.com/elastic/ingest-dev/issues/2201
Rel: https://elasticco.atlassian.net/browse/QX-282

The main question is here did I get the ownership correct, is there a better group to name?

From what I understand the main thing ownership enables is writing secrets to the repo's namespace in vault for buildkite.
@imkarrer imkarrer requested a review from watson August 14, 2023 15:09
@imkarrer imkarrer added the release_note:skip Skip the PR/issue when compiling release notes label Aug 14, 2023
@imkarrer imkarrer requested a review from ramonbutter August 14, 2023 16:33
@ramonbutter
Copy link
Contributor

I think the ownership in a "Component" is just a backstage component entity link to the team.
Maybe more owners can be defined, not sure though if this is possible.

The vault space is opened for github repos, so I believe we need to have
a github resources (with create: false) in the catalog info afaict.

Probably we can add the kibana-tests pipeline here already in this PR.

Depending on the way the solutions team wants to define their quality gates:
Those can be defined as part of this Repository, or hang into the kibana promotion flow from other external repos.

@imkarrer imkarrer requested a review from a team as a code owner August 15, 2023 17:15
@imkarrer imkarrer changed the title Create catalog-info.yaml QG Scaffold Aug 15, 2023
Copy link
Contributor

@ramonbutter ramonbutter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm,
but the final approval should come from one of the teams

@watson watson added the backport:skip This commit does not require backporting label Aug 17, 2023
Copy link
Contributor

@watson watson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general it looks good. I have a bunch of questions, mostly related to catalog-info.yaml. But I'm sure it's just me still learning...

catalog-info.yaml Outdated Show resolved Hide resolved
catalog-info.yaml Show resolved Hide resolved
catalog-info.yaml Show resolved Hide resolved
catalog-info.yaml Outdated Show resolved Hide resolved
Comment on lines 7 to 10
- label: ":pipeline::fleet::seedling: Trigger Fleet Kibana Tests for ${ENVIRONMENT}"
command: echo "replace me with Fleet specific Kibana tests"
agent:
image: "docker.elastic.co/ci-agent-images/basic-buildkite-agent:1688566364"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @juliaElastic this and the pipeline below for staging is where we may hook in the smoke pipeline you're working on. Please leave any feedback here if you see any problems.

Copy link
Member

@jbudz jbudz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pipelines / casing check LGTM

Copy link
Contributor

@rhass rhass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jbudz jbudz mentioned this pull request Aug 21, 2023
9 tasks
@ramonbutter
Copy link
Contributor

@watson, from our side this is ready to go.
Any idea about the failing checks?

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #12 / aiops change point detection shows multiple results when split field is selected

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@ramonbutter ramonbutter merged commit 58334b5 into elastic:main Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes v8.11.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants