-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Index Management] Add enrich policies fetch api and expose in plugin api #163556
[Index Management] Add enrich policies fetch api and expose in plugin api #163556
Conversation
Pinging @elastic/platform-deployment-management (Team:Deployment Management) |
x-pack/plugins/index_management/public/services/public_api_service.ts
Outdated
Show resolved
Hide resolved
x-pack/plugins/index_management/server/routes/api/enrich_policies/register_list_route.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job, @sabarasaba! 🚀
Tested locally and the api service works as expected. I left a couple of comments in the code, please let me know what you think.
Other than that, I think we should also add some api integration tests for the new route to this folder, but this could also be done in a separate PR.
@elasticmachine merge upstream |
Thanks for the review @yuliacech! I've addressed your comments with a4e984e. In regards of the API integration tests I'll aim to have all of them together in a later iteration to avoid bloating in the PRs. I've created an issue for that and also integrated that into the project plan: #163807 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Latest changes LGTM! Thanks a lot for addressing my comments 👍
💚 Build Succeeded
Metrics [docs]Module Count
Public APIs missing comments
Async chunks
Public APIs missing exports
Page load bundle
History
To update your PR or re-run it, just comment with: cc @sabarasaba |
Related to #163159
Summary
In order to unblock the esql team working on the kibana implementation, I'll first merge the API changes for listing enrich policies and a client side public api interface for exposing this mechanism so that the consumer plugins can use it.
Consumers of this plugin can use public
apiService
from index management by first adding theindexManagement
plugin as a dependency of their plugin and then proceding to invoke the method as:Which will then return a serialized list of enriched policies that look something like:
How to test
yarn es snapshot --license=trial
and serverless search solution withyarn start
indexManagement?.apiService.getAllEnrichPolicies();
enrich policies
has been firedCreate a policy