[7.17] [FTR - esArchiver] Update saved_objects_management test archives to reduce flakiness (#162259)
#163479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… reduce flakiness (elastic#162259) ## Summary Part of elastic#161882 Updates all archives of the `test/functional/fixtures/es_archiver/saved_objects_management` test suite: * Removing SO index definitions. * Updating documents defined in `data.json`. (cherry picked from commit 59450f0) # Conflicts: # test/functional/fixtures/es_archiver/saved_objects_management/hidden_from_http_apis/data.json # test/functional/fixtures/es_archiver/saved_objects_management/hidden_saved_objects/data.json # test/functional/fixtures/es_archiver/saved_objects_management/hidden_types/data.json # test/functional/fixtures/es_archiver/saved_objects_management/hidden_types/mappings.json # x-pack/test/functional/es_archives/visualize/default/mappings.json
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]
History
To update your PR or re-run it, just comment with: cc @gsoldevila |
afharo
reviewed
Aug 11, 2023
| @@ -21,7 +21,6 @@ export default function ({ getService, getPageObjects }: PluginFunctionalProvide | |||
| const esArchiver = getService('esArchiver'); | |||
| const testSubjects = getService('testSubjects'); | |||
|
|
|||
| // Failing: See https://github.com/elastic/kibana/issues/116059 | |||
| // Failing: See https://github.com/elastic/kibana/issues/116059 | |||
| describe.skip('saved objects management with hidden types', () => { | |||
There was a problem hiding this comment.
This is still skipped. Is that intentional?
There was a problem hiding this comment.
Yes, I took a look at that one too but it wasn't related.
Couldn't help cleaning the duplicate comment though 😅
NB that it's not part of the list in the description.
afharo
approved these changes
Aug 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto7.17:saved_objects_managementtest archives to reduce flakiness (#162259)Related issues:
isExportablethrows" #131834Questions ?
Please refer to the Backport tool documentation