[Cases] Fix flaky test in user actions pagination #163474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adcoelho
added
release_note:skip
|
Pinging @elastic/response-ops (Team:ResponseOps) |
|
Pinging @elastic/response-ops-cases (Feature:Cases) |
delanni
added
release_note:skip
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: cc @adcoelho |
bryce-b
pushed a commit
to bryce-b/kibana
that referenced
this pull request
Aug 9, 2023
Fixes elastic#156750 Fixes elastic#156747 Fixes elastic#156744 Fixes elastic#156743 Fixes elastic#156748 Fixes elastic#156746 Fixes elastic#156745 Fixes elastic#156749 ## Summary Basically what you suggested offline @js-jankisalvi. | Scenario | Old Test | Functional test where it is covered | | ------------- | ------------- | ------------- | | Only shows one list of user actions when `total_user_actions < 10` | `'renders only one action list when user actions are less than or equal to 10'` | `'initially renders user actions list correctly'`| | `Show More` button does not show up when `total_user_actions <= page_size` | `'shows more button visible 21st user action added'` | `'initially renders user actions list correctly'` | | Shows 2 user action lists when `total_user_actions > page_size` | `'renders two user actions list when user actions are more than 10'` | `'shows more actions on button click'` | | loading spinner | `'Loading spinner when user actions loading'` | `'shows more actions on button click'` | ## Flaky Test Runner Let's make sure that the functional tests don't become flaky too. https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2826
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #156750
Fixes #156747
Fixes #156744
Fixes #156743
Fixes #156748
Fixes #156746
Fixes #156745
Fixes #156749
Summary
Basically what you suggested offline @js-jankisalvi.
total_user_actions < 10'renders only one action list when user actions are less than or equal to 10''initially renders user actions list correctly'Show Morebutton does not show up whentotal_user_actions <= page_size'shows more button visible 21st user action added''initially renders user actions list correctly'total_user_actions > page_size'renders two user actions list when user actions are more than 10''shows more actions on button click''Loading spinner when user actions loading''shows more actions on button click'Flaky Test Runner
Let's make sure that the functional tests don't become flaky too.
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2826