-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Infra UI] Fix flyout-related tests #163469
Merged
crespocarlos
merged 1 commit into
elastic:main
from
crespocarlos:162672-host-view-flyout-test-fix
Aug 9, 2023
Merged
[Infra UI] Fix flyout-related tests #163469
crespocarlos
merged 1 commit into
elastic:main
from
crespocarlos:162672-host-view-flyout-test-fix
Aug 9, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
crespocarlos
added
Feature:Metrics UI
Metrics UI feature
Team:Infra Monitoring UI - DEPRECATED
DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services
release_note:skip
Skip the PR/issue when compiling release notes
backport:skip
This commit does not require backporting
Feature:ObsHosts
Hosts feature within Observability
v8.10.0
labels
Aug 9, 2023
crespocarlos
changed the title
Fix flyout related tests
[Infra UI] Fix flyout-related tests
Aug 9, 2023
crespocarlos
force-pushed
the
162672-host-view-flyout-test-fix
branch
from
August 9, 2023 12:10
fdb5a1e
to
c2b039c
Compare
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
Pinging @elastic/infra-monitoring-ui (Team:Infra Monitoring UI) |
jennypavlova
approved these changes
Aug 9, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀 All tests passed locally, thanks for the fixes!
bryce-b
pushed a commit
to bryce-b/kibana
that referenced
this pull request
Aug 9, 2023
closes [elastic#162672](elastic#162672) ## Summary This PR fixes the `should render alerts count for a host inside a flyout`. It also moves all flyout-related tests to the `#Single Host Flyout` test. ### How to test ```bash yarn test:ftr:server --config x-pack/test/functional/apps/infra/config.ts ``` ```bash yarn test:ftr:runner --config x-pack/test/functional/apps/infra/config.ts --include x-pack/test/functional/apps/infra/hosts_view.ts ``` https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2830
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport:skip
This commit does not require backporting
Feature:Metrics UI
Metrics UI feature
Feature:ObsHosts
Hosts feature within Observability
release_note:skip
Skip the PR/issue when compiling release notes
Team:Infra Monitoring UI - DEPRECATED
DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services
v8.10.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #162672
Summary
This PR fixes the
should render alerts count for a host inside a flyout
. It also moves all flyout-related tests to the#Single Host Flyout
test.How to test
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2830