Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Infra UI] Fix flyout-related tests #163469

Merged

Conversation

crespocarlos
Copy link
Contributor

@crespocarlos crespocarlos commented Aug 9, 2023

closes #162672

Summary

This PR fixes the should render alerts count for a host inside a flyout. It also moves all flyout-related tests to the #Single Host Flyout test.

How to test

yarn test:ftr:server --config x-pack/test/functional/apps/infra/config.ts
yarn test:ftr:runner --config x-pack/test/functional/apps/infra/config.ts --include x-pack/test/functional/apps/infra/hosts_view.ts

https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2830

@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • /oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@crespocarlos crespocarlos added Feature:Metrics UI Metrics UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting Feature:ObsHosts Hosts feature within Observability v8.10.0 labels Aug 9, 2023
@crespocarlos crespocarlos changed the title Fix flyout related tests [Infra UI] Fix flyout-related tests Aug 9, 2023
@crespocarlos crespocarlos force-pushed the 162672-host-view-flyout-test-fix branch from fdb5a1e to c2b039c Compare August 9, 2023 12:10
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

  • 💚 Build #148649 succeeded fdb5a1e1d2128528faf35a0a9d086f47620e2449

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@crespocarlos crespocarlos marked this pull request as ready for review August 9, 2023 14:54
@crespocarlos crespocarlos requested a review from a team as a code owner August 9, 2023 14:54
@elasticmachine
Copy link
Contributor

Pinging @elastic/infra-monitoring-ui (Team:Infra Monitoring UI)

@jennypavlova jennypavlova self-requested a review August 9, 2023 16:26
Copy link
Member

@jennypavlova jennypavlova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀 All tests passed locally, thanks for the fixes!

@crespocarlos crespocarlos merged commit 949c2fb into elastic:main Aug 9, 2023
@crespocarlos crespocarlos deleted the 162672-host-view-flyout-test-fix branch August 9, 2023 16:42
bryce-b pushed a commit to bryce-b/kibana that referenced this pull request Aug 9, 2023
closes [elastic#162672](elastic#162672)
## Summary

This PR fixes the `should render alerts count for a host inside a
flyout`. It also moves all flyout-related tests to the `#Single Host
Flyout` test.


### How to test

```bash
yarn test:ftr:server --config x-pack/test/functional/apps/infra/config.ts
```

```bash
yarn test:ftr:runner --config x-pack/test/functional/apps/infra/config.ts --include x-pack/test/functional/apps/infra/hosts_view.ts
```


https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2830
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:Metrics UI Metrics UI feature Feature:ObsHosts Hosts feature within Observability release_note:skip Skip the PR/issue when compiling release notes Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v8.10.0
Projects
None yet
5 participants