[ML] Fixes capabilities polling in manage page #163399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgowdyelastic
added
bug
|
Pinging @elastic/ml-ui (:ml) |
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
bryce-b
pushed a commit
to bryce-b/kibana
that referenced
this pull request
Aug 9, 2023
On ML's management page a new capabilities poll is created every time the user changes tabs. `getMlGlobalServices` gets called every time the jobs list renders, which creates a new `MlCapabilitiesService` which creates a new timer to poll for ml's capabilities. This change moves the `mlServices` so it isn't called on each render. It also bumps up the interval from 1 min to 5 mins as think 1 min is a bit too frequent.
jgowdyelastic
changed the title
szabosteve
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On ML's management page a new capabilities poll is created every time the user changes tabs.
getMlGlobalServicesgets called every time the jobs list renders, which creates a newMlCapabilitiesServicewhich creates a new timer to poll for ml's capabilities.This change moves the
mlServicesso it isn't called on each render.It also bumps up the interval from 1 min to 5 mins as think 1 min is a bit too frequent.