Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Data Frame Analytics functional tests: remove unnecessary version check #163343

Merged

Conversation

alvarezmelissa87
Copy link
Contributor

@alvarezmelissa87 alvarezmelissa87 commented Aug 7, 2023

Summary

Fixes #163220
Fixes #163338

Flaky test run https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2808

Checklist

Delete any items that are not applicable to this PR.

@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@alvarezmelissa87 alvarezmelissa87 added v8.10.0 release_note:skip Skip the PR/issue when compiling release notes labels Aug 7, 2023
@alvarezmelissa87 alvarezmelissa87 requested a review from qn895 August 7, 2023 17:29
@qn895
Copy link
Member

qn895 commented Aug 7, 2023

LGTM 🎉

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @alvarezmelissa87

@alvarezmelissa87 alvarezmelissa87 merged commit 25c7852 into elastic:main Aug 7, 2023
@alvarezmelissa87 alvarezmelissa87 deleted the ml-dfa-functional-test-fix branch August 7, 2023 18:56
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Aug 7, 2023
peteharverson added a commit that referenced this pull request Aug 8, 2023
## Summary

Unskips the data frame analytics tests that were fixed in
#163343 and skipped in
#163220 and
#163338

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
bryce-b pushed a commit to bryce-b/kibana that referenced this pull request Aug 9, 2023
…n check (elastic#163343)

## Summary

Fixes elastic#163220
Fixes elastic#163338

Flaky test run
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2808


### Checklist

Delete any items that are not applicable to this PR.

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
bryce-b pushed a commit to bryce-b/kibana that referenced this pull request Aug 9, 2023
## Summary

Unskips the data frame analytics tests that were fixed in
elastic#163343 and skipped in
elastic#163220 and
elastic#163338

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment