[Enterprise Search] Reuse serverless panels on Enterprise Search #163179

efegurkan · 2023-08-04T14:47:50Z

Summary

Reuse Serverless panels for API index overview.
Updated Enterprise Search overview to latests designs.

Note: There will be another PR for layout changes on overview afterwards.

Screen.Recording.2023-08-09.at.01.55.24.mov

Screen.Recording.2023-08-09.at.01.52.20.mov

Screen.Recording.2023-08-09.at.01.55.49.mov

Checklist

Delete any items that are not applicable to this PR.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
Any UI touched in this PR is usable by keyboard only (learn more about keyboard accessibility)
Any UI touched in this PR does not create any new axe failures (run axe in browser: FF, Chrome)
This renders correctly on smaller devices using a responsive layout. (You can test this in your browser)
This was checked for cross-browser compatibility

efegurkan · 2023-08-04T14:49:12Z

packages/kbn-serverless-api-panels/languages/javascript.ts

+import { i18n } from '@kbn/i18n';
+import { LanguageDefinition, Languages } from './types';
+
+const docLinks = {


Replace these on all languages files

efegurkan · 2023-08-04T14:55:05Z

x-pack/plugins/serverless_search/public/application/components/search-connector.svg

TattdCodeMonkey

I'm not sure we can wholesale re-use the copy from the serverless page in dedicated. I would expect things to diverge.

We definitely cannot share the language definitions since the clients will be different. We're just waiting on the serverless clients to be available before we update the install snippets.

TattdCodeMonkey · 2023-08-04T15:00:20Z

package.json

@@ -616,6 +616,7 @@
    "@kbn/server-http-tools": "link:packages/kbn-server-http-tools",
    "@kbn/server-route-repository": "link:packages/kbn-server-route-repository",
    "@kbn/serverless": "link:x-pack/plugins/serverless",
+    "@kbn/serverless-api-panels": "link:packages/kbn-serverless-api-panels",


should this be search-api-panels to be generically named for either search solution. I know we want to avoid the use "serverless" specifically where possible.

TattdCodeMonkey · 2023-08-04T15:06:33Z

packages/kbn-serverless-api-panels/languages/go.ts

+  
+  fmt.Println(res, err)
+}`,
+  installClient: 'go get -u github.com/elastic/elasticsearch-serverless-go@latest',


We won't be able to share language definitions between serverless and dedicated, they will have different clients.

efegurkan · 2023-08-09T00:04:10Z

We should be finally ready for review please take a look.

@elastic/ent-search-design
@elastic/enterprise-search-frontend
@elastic/kibana-design
@elastic/ent-search-docs-team

…fix'

sphilipse · 2023-08-09T10:06:22Z

packages/kbn-search-api-panels/components/install_client.tsx

+  http,
+  pluginId,
+}) => {
+  switch (language) {


We have a couple more languages now that we should add here.

sphilipse

Haven't done an in-depth review but honestly this looks pretty good overall?

...lic/applications/enterprise_search_overview/components/product_selector/product_selector.tsx

leemthompo · 2023-08-09T12:58:12Z

I'm not sure we can wholesale re-use the copy from the serverless page in dedicated. I would expect things to diverge.

@TattdCodeMonkey this is a big PR, can you indicate where we should be looking out for incongruous copy? 😄

…e_search_overview/components/product_selector/product_selector.tsx Co-authored-by: Liam Thompson <[email protected]>

efegurkan · 2023-08-10T08:07:24Z

@elasticmachine merge upstream

sphilipse

Given that CI passes and I see no major concerns, I'm approving :)

efegurkan · 2023-08-11T10:10:35Z

@elasticmachine merge upstream

kibana-ci · 2023-08-11T11:17:28Z

💚 Build Succeeded

Buildkite Build
Commit: 2fa5e24

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`enterpriseSearch`	2156	2200	+44
`serverlessSearch`	95	98	+3
total			+47

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
`@kbn/search-api-panels`	-	58	+58

Any counts in public APIs

Total count of every any typed public API. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats any for more detailed information.

id	before	after	diff
`@kbn/search-api-panels`	-	1	+1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`enterpriseSearch`	2.6MB	2.6MB	+29.0KB
`serverlessSearch`	70.9KB	72.8KB	+1.9KB
total			+30.8KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`enterpriseSearch`	38.5KB	38.7KB	+266.0B

Unknown metric groups

API count

id	before	after	diff
`@kbn/search-api-panels`	-	58	+58

async chunk count

id	before	after	diff
`enterpriseSearch`	18	19	+1

miscellaneous assets size

id	before	after	diff
`enterpriseSearch`	2.6MB	3.2MB	⚠️ +634.6KB

History

💚 Build #149170 succeeded eebc476
💚 Build #149075 succeeded d936440
💔 Build #148775 failed 4b697bf
💔 Build #148749 failed afc81bb
💔 Build #148726 failed 1e914cc
💔 Build #148697 failed 4a23b8c

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

efegurkan requested review from a team as code owners August 4, 2023 14:47

efegurkan requested a review from a team August 4, 2023 14:47

efegurkan added release_note:skip Skip the PR/issue when compiling release notes Team:EnterpriseSearch v8.10.0 labels Aug 4, 2023

efegurkan commented Aug 4, 2023

View reviewed changes

efegurkan marked this pull request as draft August 4, 2023 14:50

efegurkan commented Aug 4, 2023

View reviewed changes

x-pack/plugins/serverless_search/public/application/components/search-connector.svg Outdated

Copy link

Member Author

efegurkan Aug 4, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicate

TattdCodeMonkey reviewed Aug 4, 2023

View reviewed changes

efegurkan force-pushed the reuse-getting-started-from-serverless branch 5 times, most recently from ca10574 to 29ab014 Compare August 8, 2023 23:46

efegurkan marked this pull request as ready for review August 9, 2023 00:02

efegurkan requested a review from a team August 9, 2023 00:02

efegurkan force-pushed the reuse-getting-started-from-serverless branch from 83e48de to 80f8f27 Compare August 9, 2023 00:21

efegurkan and others added 11 commits August 9, 2023 12:55

Move serverless panels to a separate shareable package

d3c3ebe

Add getting started components to enterprise search

c689908

review changes part

67361c3

Overview panel visual props

2e186f3

fix i18n setup

88c4dd6

Fix doclinks for clients

4c535a8

DocLinks overhaul

8c94446

Overview overhaul

4d9efb5

Fix tests

c471fbd

Fix filenames

20a8366

[CI] Auto-commit changed files from 'node scripts/lint_ts_projects --…

5ef3e44

…fix'

kibanamachine and others added 2 commits August 9, 2023 12:55

[CI] Auto-commit changed files from 'node scripts/generate codeowners'

c0dd8d6

Remove leftover file

1f0a7ed

efegurkan force-pushed the reuse-getting-started-from-serverless branch from 9191f3e to 1f0a7ed Compare August 9, 2023 10:55

sphilipse reviewed Aug 9, 2023

View reviewed changes

Use correct endpoint for userprofile

4a23b8c

sphilipse reviewed Aug 9, 2023

View reviewed changes

Fix test

1e914cc

leemthompo reviewed Aug 9, 2023

View reviewed changes

...lic/applications/enterprise_search_overview/components/product_selector/product_selector.tsx Outdated Show resolved Hide resolved

efegurkan and others added 2 commits August 9, 2023 15:30

Update x-pack/plugins/enterprise_search/public/applications/enterpris…

afc81bb

…e_search_overview/components/product_selector/product_selector.tsx Co-authored-by: Liam Thompson <[email protected]>

fix unterminated string issue

4b697bf

kibanamachine and others added 2 commits August 10, 2023 04:07

Merge branch 'main' into reuse-getting-started-from-serverless

d936440

Merge branch 'main' into reuse-getting-started-from-serverless

eebc476

sphilipse approved these changes Aug 10, 2023

View reviewed changes

Merge branch 'main' into reuse-getting-started-from-serverless

2fa5e24

efegurkan enabled auto-merge (squash) August 11, 2023 14:42

daveyholler approved these changes Aug 11, 2023

View reviewed changes

leemthompo approved these changes Aug 11, 2023

View reviewed changes

efegurkan merged commit 1e7efae into elastic:main Aug 11, 2023

kibanamachine added the backport:skip This commit does not require backporting label Aug 11, 2023

efegurkan deleted the reuse-getting-started-from-serverless branch October 26, 2023 12:57

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Enterprise Search] Reuse serverless panels on Enterprise Search #163179

[Enterprise Search] Reuse serverless panels on Enterprise Search #163179

efegurkan commented Aug 4, 2023 •

edited

Loading

efegurkan Aug 4, 2023

efegurkan Aug 4, 2023

TattdCodeMonkey left a comment

TattdCodeMonkey Aug 4, 2023

TattdCodeMonkey Aug 4, 2023

efegurkan commented Aug 9, 2023

sphilipse Aug 9, 2023

sphilipse left a comment

leemthompo commented Aug 9, 2023

efegurkan commented Aug 10, 2023

sphilipse left a comment

efegurkan commented Aug 11, 2023

kibana-ci commented Aug 11, 2023

API count

async chunk count

miscellaneous assets size

[Enterprise Search] Reuse serverless panels on Enterprise Search #163179

[Enterprise Search] Reuse serverless panels on Enterprise Search #163179

Conversation

efegurkan commented Aug 4, 2023 • edited Loading

Summary

Checklist

efegurkan Aug 4, 2023

Choose a reason for hiding this comment

efegurkan Aug 4, 2023

Choose a reason for hiding this comment

TattdCodeMonkey left a comment

Choose a reason for hiding this comment

TattdCodeMonkey Aug 4, 2023

Choose a reason for hiding this comment

TattdCodeMonkey Aug 4, 2023

Choose a reason for hiding this comment

efegurkan commented Aug 9, 2023

sphilipse Aug 9, 2023

Choose a reason for hiding this comment

sphilipse left a comment

Choose a reason for hiding this comment

leemthompo commented Aug 9, 2023

efegurkan commented Aug 10, 2023

sphilipse left a comment

Choose a reason for hiding this comment

efegurkan commented Aug 11, 2023

kibana-ci commented Aug 11, 2023

💚 Build Succeeded

Metrics [docs]

Module Count

Public APIs missing comments

Any counts in public APIs

Async chunks

Page load bundle

API count

async chunk count

miscellaneous assets size

History

efegurkan commented Aug 4, 2023 •

edited

Loading