Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Index Management] Remove a11y test that is no longer applicable #163113

Merged

Conversation

alisonelizabeth
Copy link
Contributor

@alisonelizabeth alisonelizabeth commented Aug 3, 2023

Fixes #128836

This removes the a11y tests associated with the index details flyout. I started looking into it (passes locally btw), but then decided it doesn't make sense to dedicate too much effort in this since the flyout functionality will soon be removed as part of #162644.

@alisonelizabeth alisonelizabeth changed the title [Index Management] Re-enable a11y test [Index Management] Remove a11y test that is no longer applicable Aug 3, 2023
@alisonelizabeth alisonelizabeth marked this pull request as ready for review August 3, 2023 18:34
@alisonelizabeth alisonelizabeth requested a review from a team as a code owner August 3, 2023 18:34
@alisonelizabeth alisonelizabeth added Feature:Index Management Index and index templates UI Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more release_note:skip Skip the PR/issue when compiling release notes labels Aug 3, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/platform-deployment-management (Team:Deployment Management)

@alisonelizabeth
Copy link
Contributor Author

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@yuliacech yuliacech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for checking these tests, @alisonelizabeth!
I agree with removing the flyouts tests for now due to them being flaky. I'll make sure a11y tests are included into upcoming Index Management work.

@alisonelizabeth alisonelizabeth merged commit f90c800 into elastic:main Aug 4, 2023
@alisonelizabeth alisonelizabeth deleted the a11y/index_details_flaky_test branch August 4, 2023 13:09
@kibanamachine kibanamachine added v8.10.0 backport:skip This commit does not require backporting labels Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:Index Management Index and index templates UI release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v8.10.0
Projects
None yet
5 participants