Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Migrate all usages of EuiPage*_Deprecated in Data Visualizer #163029

Merged
merged 2 commits into from
Aug 7, 2023

Conversation

qn895
Copy link
Member

@qn895 qn895 commented Aug 2, 2023

Summary

Part of #161408. This PR migrates usages of the deprecated EuiPages* components to the EuiPageTemplate in Data visualizer plugin.

Checklist

@qn895 qn895 added :ml release_note:skip Skip the PR/issue when compiling release notes v8.1.0 labels Aug 2, 2023
@qn895 qn895 requested review from walterra and peteharverson August 2, 2023 21:40
@qn895 qn895 requested a review from a team as a code owner August 2, 2023 21:40
@qn895 qn895 self-assigned this Aug 2, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and LGTM

@qn895
Copy link
Member Author

qn895 commented Aug 7, 2023

@elasticmachine merge upstream

@qn895 qn895 enabled auto-merge (squash) August 7, 2023 15:02
@qn895 qn895 merged commit 8fa3551 into elastic:main Aug 7, 2023
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
dataVisualizer 604.9KB 604.6KB -269.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @qn895

@kibanamachine
Copy link
Contributor

💔 Some backports could not be created

Status Branch Result
8.1 Backport failed because of merge conflicts
8.9

Note: Successful backport PRs will be merged automatically after passing CI.

Manual backport

To create the backport manually run:

node scripts/backport --pr 163029

Questions ?

Please refer to the Backport tool documentation

@qn895 qn895 removed the v8.1.0 label Aug 7, 2023
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Aug 7, 2023
bryce-b pushed a commit to bryce-b/kibana that referenced this pull request Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting :ml release_note:skip Skip the PR/issue when compiling release notes v8.10.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants