Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solutions] Flaky entity analytics cypress #162963

Merged

Conversation

machadoum
Copy link
Member

@machadoum machadoum commented Aug 2, 2023

Original issue: #161874

Summary

Flaky entity analytics cypress test

Based on my analysis, it seems likely that the issue was caused by some tests failing to close the filter after opening it. This could have had an impact on the subsequent tests.
After the change, I could run the test successfully more than 60 times.
Here is a print from some of these runs:
Screenshot 2023-08-04 at 13 58 55

@machadoum machadoum force-pushed the fix-flaky-entity-analytics-cypress branch from 361be9c to 4ab1064 Compare August 3, 2023 13:08
@machadoum machadoum changed the title [] Flaky cypress [Security Solutions] Flaky entity analytics cypress Aug 3, 2023
@machadoum machadoum self-assigned this Aug 3, 2023
@machadoum machadoum force-pushed the fix-flaky-entity-analytics-cypress branch from c9df72f to b269627 Compare August 4, 2023 11:55
@machadoum machadoum marked this pull request as ready for review August 4, 2023 12:02
@machadoum machadoum requested review from a team as code owners August 4, 2023 12:02
@machadoum machadoum added release_note:skip Skip the PR/issue when compiling release notes Team:Threat Hunting Security Solution Threat Hunting Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Explore labels Aug 4, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

Copy link
Contributor

@semd semd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

  • 💚 Build #147158 succeeded c9df72f79aaa8ee2685ab324d0c0efba3fd88ff5
  • 💔 Build #146744 failed 361be9c94539574187cdac2798daec3a90e7f959

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @machadoum

@machadoum machadoum merged commit 5a3e33d into elastic:main Aug 7, 2023
@kibanamachine kibanamachine added v8.10.0 backport:skip This commit does not require backporting labels Aug 7, 2023
bryce-b pushed a commit to bryce-b/kibana that referenced this pull request Aug 9, 2023
Original issue: elastic#161874

## Summary

Flaky entity analytics cypress test

Based on my analysis, it seems likely that the issue was caused by some
tests failing to close the filter after opening it. This could have had
an impact on the subsequent tests.
After the change, I could run the test successfully more than 60 times.
Here is a print from some of these runs: 
<img width="587" alt="Screenshot 2023-08-04 at 13 58 55"
src="https://github.com/elastic/kibana/assets/1490444/02367810-3616-4fa2-a82e-48c19e6ac4b6">
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Explore Team:Threat Hunting Security Solution Threat Hunting Team v8.10.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants