-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Security Solutions] Flaky entity analytics cypress #162963
Merged
machadoum
merged 2 commits into
elastic:main
from
machadoum:fix-flaky-entity-analytics-cypress
Aug 7, 2023
Merged
[Security Solutions] Flaky entity analytics cypress #162963
machadoum
merged 2 commits into
elastic:main
from
machadoum:fix-flaky-entity-analytics-cypress
Aug 7, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
machadoum
force-pushed
the
fix-flaky-entity-analytics-cypress
branch
from
August 3, 2023 13:08
361be9c
to
4ab1064
Compare
machadoum
changed the title
[] Flaky cypress
[Security Solutions] Flaky entity analytics cypress
Aug 3, 2023
machadoum
force-pushed
the
fix-flaky-entity-analytics-cypress
branch
from
August 4, 2023 11:55
c9df72f
to
b269627
Compare
machadoum
added
release_note:skip
Skip the PR/issue when compiling release notes
Team:Threat Hunting
Security Solution Threat Hunting Team
Team: SecuritySolution
Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc.
Team:Threat Hunting:Explore
labels
Aug 4, 2023
Pinging @elastic/security-threat-hunting (Team:Threat Hunting) |
Pinging @elastic/security-solution (Team: SecuritySolution) |
semd
approved these changes
Aug 4, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: cc @machadoum |
kibanamachine
added
v8.10.0
backport:skip
This commit does not require backporting
labels
Aug 7, 2023
bryce-b
pushed a commit
to bryce-b/kibana
that referenced
this pull request
Aug 9, 2023
Original issue: elastic#161874 ## Summary Flaky entity analytics cypress test Based on my analysis, it seems likely that the issue was caused by some tests failing to close the filter after opening it. This could have had an impact on the subsequent tests. After the change, I could run the test successfully more than 60 times. Here is a print from some of these runs: <img width="587" alt="Screenshot 2023-08-04 at 13 58 55" src="https://github.com/elastic/kibana/assets/1490444/02367810-3616-4fa2-a82e-48c19e6ac4b6">
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport:skip
This commit does not require backporting
release_note:skip
Skip the PR/issue when compiling release notes
Team: SecuritySolution
Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc.
Team:Threat Hunting:Explore
Team:Threat Hunting
Security Solution Threat Hunting Team
v8.10.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original issue: #161874
Summary
Flaky entity analytics cypress test
Based on my analysis, it seems likely that the issue was caused by some tests failing to close the filter after opening it. This could have had an impact on the subsequent tests.
After the change, I could run the test successfully more than 60 times.
Here is a print from some of these runs: